Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Do not merge] Enable NLL for a crater run #53426

Closed
wants to merge 1 commit into from
Closed

[Do not merge] Enable NLL for a crater run #53426

wants to merge 1 commit into from

Conversation

lqd
Copy link
Member

@lqd lqd commented Aug 16, 2018

This enables the MIR borrowck and two-phase-borrows by default, so that we can start the next NLL crater run (#53171).

@rust-highfive
Copy link
Collaborator

r? @michaelwoerister

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 16, 2018
@Mark-Simulacrum
Copy link
Member

r? @nikomatsakis or @pnkfelix to make sure this is the correct patch but let's get the ball rolling at least

@bors try

@bors
Copy link
Contributor

bors commented Aug 16, 2018

⌛ Trying commit d5bb4f5ea8c4046d58d34c5627a39b4aac03fc1a with merge a5d98b025f62ace80fe9d2a15781f900fc42515e...

@bors
Copy link
Contributor

bors commented Aug 16, 2018

☀️ Test successful - status-travis
State: approved= try=True

@nikomatsakis
Copy link
Contributor

cc @rust-lang/infra -- can somebody start a check-only crater run here? I don't know what is required =)

@Mark-Simulacrum
Copy link
Member

@craterbot run start=master#142bb27373126edf8367f526358b6c72ecf1d8df end=try#a5d98b025f62ace80fe9d2a15781f900fc42515e mode=check-only cap-lints=warn

@craterbot
Copy link
Collaborator

👌 Experiment pr-53426 created and queued.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 16, 2018
@craterbot
Copy link
Collaborator

🚧 Experiment pr-53426 is now running on agent crater-1.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-53426 is completed!
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Aug 18, 2018
@Eh2406
Copy link
Contributor

Eh2406 commented Aug 18, 2018

What is the recommended algorithm for reviewing this kanda Crater run?

Just from poking around, there are a lot of ICE's:
thread 'main' panicked at 'scrape_region_constraints: incoming region obligations = [
actix-0.5.8
... the rest of the actix.* ...
add-remote-2.0.1
africastalking_gateway-0.1.0
agnes-0.1.5
airkorea-0.1.2

@memoryruins
Copy link
Contributor

memoryruins commented Aug 18, 2018 •
edited
Loading

@Eh2406 my current algorithm is clicking through them one by one on mobile haha

As noted by @lqd in the crater-run-and-analysis thread in Zulip, 568/962 ICEs are because of scrape_region_constraints. A handful of recent issues were opened and tracked in #52992 and #53182. The other ICE is unresolved inference variable in outlives, which might be a return of #52057.

@lqd lqd mentioned this pull request Aug 19, 2018
Closed
2 tasks
@lqd
Copy link
Member Author

lqd commented Aug 19, 2018

(Sorry I mentioned on Zulip I was crunching through the ICEs, but not here)

@lqd
Copy link
Member Author

lqd commented Aug 21, 2018

Closing as this has been taken care of :)

@lqd lqd closed this Aug 21, 2018
@lqd lqd changed the title [Do not merge] Enable NLL by default for a crater run [Do not merge] Enable NLL for a perf run Sep 5, 2018
@pietroalbini
Copy link
Member

@bors try

@bors
Copy link
Contributor

bors commented Sep 5, 2018

⌛ Trying commit 423e7f51691c708274f7a709b64ff8ecf14892ad with merge 3a8b7311d49570250afdeba6b45e5e7de7bca050...

@lqd
Copy link
Member Author

lqd commented Sep 13, 2018

👋

@lqd lqd reopened this Sep 13, 2018
@lqd lqd changed the title [Do not merge] Enable NLL for a perf run [Do not merge] Enable NLL for a crater run Sep 13, 2018
@pnkfelix
Copy link
Member

@bors try

@bors
Copy link
Contributor

bors commented Sep 14, 2018

⌛ Trying commit bed1453 with merge e3ede4ae5297558caacf160ecf523f3a5759f682...

@bors
Copy link
Contributor

bors commented Sep 14, 2018

☀️ Test successful - status-travis
State: approved= try=True

@pnkfelix
Copy link
Member

@craterbot run name=pr-53426-2 start=master#fccde0018a618eb6f45d2a3c97f629809994dff6 end=try#e3ede4ae5297558caacf160ecf523f3a5759f682 mode=check-only cap-lints=warn

@craterbot
Copy link
Collaborator

👌 Experiment pr-53426-2 created and queued.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 14, 2018
@craterbot
Copy link
Collaborator

🚧 Experiment pr-53426-2 is now running on agent aws-2.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-53426-2 is completed!
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Sep 15, 2018
@lqd
Copy link
Member Author

lqd commented Sep 15, 2018

results look good 👍

@lqd lqd closed this Sep 15, 2018
@pietroalbini pietroalbini reopened this Sep 16, 2018
@pietroalbini
Copy link
Member

Rescheduling the run because some errors were ignored by Crater.

@craterbot run name=pr-53426-3 start=master#fccde0018a618eb6f45d2a3c97f629809994dff6 end=try#e3ede4ae5297558caacf160ecf523f3a5759f682 mode=check-only cap-lints=warn

@craterbot
Copy link
Collaborator

👌 Experiment pr-53426-3 created and queued.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 16, 2018
@craterbot
Copy link
Collaborator

🚧 Experiment pr-53426-3 is now running on agent aws-1.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-53426-3 is completed!
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Sep 17, 2018
@pietroalbini
Copy link
Member

Nothing new.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.