Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NLL ICEs from 3rd crater run #53482

Closed
2 tasks done
lqd opened this issue Aug 19, 2018 · 2 comments
Closed
2 tasks done

NLL ICEs from 3rd crater run #53482

lqd opened this issue Aug 19, 2018 · 2 comments
Labels
A-NLL Area: Non-lexical lifetimes (NLL) NLL-complete Working towards the "valid code works" goal

Comments

@lqd
Copy link
Member

lqd commented Aug 19, 2018 •
edited
Loading

Following on the ICEs from #52217, here are the 591 occurrences of ICEs in the 3rd NLL crater run from #53426 (out of the 982 regressions).

Only 2 kinds of ICEs this time:

1. 'scrape_region_constraints: incoming region obligations (#52992)

589 occurrences from what looks to be the known issue #52992. Thanks to @klemens the issue contains a minimized repro. For convenience, here's also the playground link to that repro.

List of crate failures

2. unresolved inference variable in outlives: _#3t (#53568)

2 occurrences — but the 2nd crate fails because it depends on the 1st (hyper-stub) — and what looks like a possible more obscure case of #52057.

This crate is small but pretty involved with its wrappers over hyper, tokio, and futures, resulting in a lot of associated types and bounds, and some of those 'static bounds might have a weird interaction with the NLL typeck, impl Trait, and maybe delay_span_bug.

I've minimized it to only one such error, but note that the real code has 5 or 6 of them, so it would be good to verify any potential fix on the hyper-stub crate itself rather than just this minimized repro. Playground.

List of crate failures

(Marking as deferred as this is somewhat of a meta issue)

cc #53171

edit: added some missing github-only crates, going from 568 to 591 occurrences.
@lqd lqd added A-NLL Area: Non-lexical lifetimes (NLL) WG-compiler-nll NLL-complete Working towards the "valid code works" goal labels Aug 19, 2018
@nikomatsakis nikomatsakis modified the milestone: Rust 2018 RC Aug 21, 2018
@nikomatsakis nikomatsakis mentioned this issue Aug 21, 2018
Closed
@memoryruins memoryruins mentioned this issue Aug 25, 2018
Closed
@orium
Copy link
Member

orium commented Sep 2, 2018

It seems boths types of issues had been fixed.

@lqd
Copy link
Member Author

lqd commented Sep 7, 2018

indeed they are, let's close this

@lqd lqd closed this as completed Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-NLL Area: Non-lexical lifetimes (NLL) NLL-complete Working towards the "valid code works" goal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nikomatsakis @lqd @orium