Use pathdiff crate for path_relative_from
#67108
Labels
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
Centril
added
the
T-compiler
Merged
Manishearth
added a commit
to Manishearth/rust
that referenced
this issue
Jul 18, 2020
…r=Manishearth Fix for rust-lang#67108 I wanted to tackle a simple issue, and stumbled upon rust-lang#67108: this pr removes the function which was exported to the external crate as required in the todo/issue. I've tested it with: ``` ./x.py build --stage 1 --keep-stage 1 src/librustc_codegen_ssa ``` And it looks like it's compiling
Manishearth
added a commit
to Manishearth/rust
that referenced
this issue
Jul 18, 2020
…r=Manishearth Use pathdiff crate I wanted to tackle a simple issue, and stumbled upon rust-lang#67108: this pr removes the function which was exported to the external crate as required in the todo/issue. I've tested it with: ``` ./x.py build --stage 1 --keep-stage 1 src/librustc_codegen_ssa ``` And it looks like it's compiling
Manishearth
added a commit
to Manishearth/rust
that referenced
this issue
Jul 18, 2020
…r=Manishearth Use pathdiff crate I wanted to tackle a simple issue, and stumbled upon rust-lang#67108: this pr removes the function which was exported to the external crate as required in the todo/issue. I've tested it with: ``` ./x.py build --stage 1 --keep-stage 1 src/librustc_codegen_ssa ``` And it looks like it's compiling
This was referenced Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A while ago I split out the code in rustc's
path_relative_frominto https://github.com/Manishearth/pathdiffPerhaps we should just add that as a dependency? It's basically the same code.
I'm totally okay with giving maintenance powers to other compiler folks.
The text was updated successfully, but these errors were encountered: