Use pathdiff crate #74464
Use pathdiff crate #74464
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
I'm going to r? @Manishearth as it's their crate -- I guess I'm not opposed but feels a little bit odd in some sense :) Maybe this should be an unstable API on Paths? Based on the comment here it sounds like at some point itwas... |
|
@bors r+ Yeah, it was at some point, and I made an external crate by copying out rustc's code to get access to it again. |
|
📌 Commit 4b6a027 has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 5, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
|
According to CI's logs: Unfortunatey I wasn't aware of this step. How can I request permissions for it? |
|
@bors r- Oh yeah there's src/tools/tidy/src/deps.rs |
bors
added
S-waiting-on-author
|
I've added the "pathdiff" package there, thanks! |
|
@bors r+ |
|
📌 Commit 5702ce8 has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 5, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
…r=Manishearth Fix for rust-lang#67108 I wanted to tackle a simple issue, and stumbled upon rust-lang#67108: this pr removes the function which was exported to the external crate as required in the todo/issue. I've tested it with: ``` ./x.py build --stage 1 --keep-stage 1 src/librustc_codegen_ssa ``` And it looks like it's compiling
|
For future reference, make sure to run |
…r=Manishearth Use pathdiff crate I wanted to tackle a simple issue, and stumbled upon rust-lang#67108: this pr removes the function which was exported to the external crate as required in the todo/issue. I've tested it with: ``` ./x.py build --stage 1 --keep-stage 1 src/librustc_codegen_ssa ``` And it looks like it's compiling
|
@bors r+ |
|
📌 Commit c41db4c has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 5, this pull request will be tested once the tree is reopened |
|
Will do, sorry about that and thanks for giving this PR a more meaningful name!
Will do, sorry about that and thanks for giving this issue a more meaningful name |
For the record, if you just want to make sure it compiles, But you can also replace |
…arth Rollup of 11 pull requests Successful merges: - rust-lang#72414 ( Add lazy initialization primitives to std) - rust-lang#74069 (Compare tagged/niche-filling layout and pick the best one) - rust-lang#74418 (ci: Set `shell: bash` as a default, remove duplicates) - rust-lang#74441 (bootstrap.py: patch RPATH on NixOS to handle the new zlib dependency.) - rust-lang#74444 (Add regression test for rust-lang#69414) - rust-lang#74448 (improper_ctypes_definitions: allow `Box`) - rust-lang#74449 (Test codegen of compare_exchange operations) - rust-lang#74450 (Fix `Safety` docs for `from_raw_parts_mut`) - rust-lang#74453 (Use intra-doc links in `str` and `BTreeSet`) - rust-lang#74457 (rustbuild: drop tool::should_install) - rust-lang#74464 (Use pathdiff crate) Failed merges: r? @ghost
I wanted to tackle a simple issue, and stumbled upon #67108: this pr removes the function which was exported to the external crate as required in the todo/issue.
I've tested it with:
And it looks like it's compiling