-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix HorizonOS regression in FileTimes #100249
Conversation
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
Does Horizon support any fallback, such as @bors r+ |
Fix HorizonOS regression in FileTimes The changes in rust-lang#98246 caused a regression for multiple Newlib-based systems. This is just a fix including HorizonOS to the list of targets which require a workaround. `@AzureMarker` `@ian-h-chamberlain` r? `@nagisa`
@joshtriplett from a quick look,
Edit: nevermind, I tried it with the C toolchain and got an undefined reference, so I don't think this is an option. The homebrew filesystem on the 3DS is a bit unusual, so I suppose it's not too surprising. |
Yeah I had checked for it before making the PR and found it unavailable. I’m sorry for not being active 😓 |
Fix HorizonOS regression in FileTimes The changes in rust-lang#98246 caused a regression for multiple Newlib-based systems. This is just a fix including HorizonOS to the list of targets which require a workaround. `@AzureMarker` `@ian-h-chamberlain` r? `@nagisa`
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#100249 (Fix HorizonOS regression in FileTimes) - rust-lang#100253 (Recover from mutable variable declaration where `mut` is placed before `let`) - rust-lang#100482 (Add Duration rounding change to release note) - rust-lang#100523 ([rustdoc] remove Clean trait) - rust-lang#100524 (Impl `Debug` for some structs of rustbuild) - rust-lang#100526 (Add tests for the drop behavior of some control flow constructs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
The changes in #98246 caused a regression for multiple Newlib-based systems. This is just a fix including HorizonOS to the list of targets which require a workaround.
@AzureMarker @ian-h-chamberlain
r? @nagisa