Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impl Debug for some structs of rustbuild #100524

Merged

Conversation

ohno418
Copy link
Contributor

@ohno418 ohno418 commented Aug 14, 2022

A small patch to impl Debug for some structs of rustbuild to make debugging easier.

(I was trying to impl Debug for the Config struct, but found to have a bit more things to do. So gave up for now.)

@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Aug 14, 2022
@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 14, 2022
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

Seems okay.

@bors
Copy link
Contributor

bors commented Aug 14, 2022

📌 Commit 0931358 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 14, 2022
…ild-structs, r=Mark-Simulacrum

Impl `Debug` for some structs of rustbuild

A small patch to impl `Debug` for some structs of rustbuild to make debugging easier.

(I was trying to impl `Debug` for the `Config` struct, but found to have a bit more things to do. So gave up for now.)
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 14, 2022
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#100249 (Fix HorizonOS regression in FileTimes)
 - rust-lang#100253 (Recover from mutable variable declaration where `mut` is placed before `let`)
 - rust-lang#100482 (Add Duration rounding change to release note)
 - rust-lang#100523 ([rustdoc] remove Clean trait)
 - rust-lang#100524 (Impl `Debug` for some structs of rustbuild)
 - rust-lang#100526 (Add tests for the drop behavior of some control flow constructs)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 923fe98 into rust-lang:master Aug 15, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 15, 2022
@ohno418 ohno418 deleted the impl-debug-for-some-rustbuild-structs branch August 15, 2022 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants