Do not fetch HIR node when iterating to find lint.

[cjgillot]

Addresses the regression in #101620

[rust-highfive]

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

[cjgillot]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit c9c6c50 with merge 0909a15b36343dbc55af9d62c5d3ef9228f59673...

[bors]

☀️ Try build successful - checks-actions
Build commit: 0909a15b36343dbc55af9d62c5d3ef9228f59673 (0909a15b36343dbc55af9d62c5d3ef9228f59673)

[rust-timer]

Queued 0909a15b36343dbc55af9d62c5d3ef9228f59673 with parent 294f0ee, future comparison URL.

[rust-timer]

Finished benchmarking commit (0909a15b36343dbc55af9d62c5d3ef9228f59673): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.5%	[-2.2%, -0.2%]	28
Improvements ✅ (secondary)	-12.9%	[-38.6%, -2.6%]	6
All ❌✅ (primary)	-0.5%	[-2.2%, -0.2%]	28

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.3%	[3.8%, 5.0%]	3
Improvements ✅ (primary)	-2.4%	[-2.4%, -2.4%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.4%	[-2.4%, -2.4%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-4.6%	[-9.7%, -2.1%]	4
Improvements ✅ (secondary)	-15.6%	[-31.5%, -5.8%]	4
All ❌✅ (primary)	-4.6%	[-9.7%, -2.1%]	4

Footnotes

1. the arithmetic mean of the percent change ↩ ↩² ↩³

2. number of relevant changes ↩ ↩² ↩³

[cjgillot]

r? @oli-obk
This PR supersedes #101839.

[oli-obk]

@bors r+

[bors]

📌 Commit c9c6c50 has been approved by oli-obk

It is now in the queue for this repository.

[bors]

⌛ Testing commit c9c6c50 with merge bc7b17c...

[bors]

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing bc7b17c to master...

[rust-timer]

Finished benchmarking commit (bc7b17c): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.6%	[-2.3%, -0.2%]	24
Improvements ✅ (secondary)	-13.1%	[-39.1%, -3.2%]	6
All ❌✅ (primary)	-0.6%	[-2.3%, -0.2%]	24

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.4%	[2.4%, 2.4%]	1
Improvements ✅ (primary)	-2.0%	[-2.9%, -1.0%]	9
Improvements ✅ (secondary)	-2.4%	[-3.6%, -1.9%]	8
All ❌✅ (primary)	-2.0%	[-2.9%, -1.0%]	9

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	2.1%	[2.1%, 2.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.3%	[-4.2%, -2.0%]	4
Improvements ✅ (secondary)	-15.7%	[-31.5%, -5.8%]	4
All ❌✅ (primary)	-2.2%	[-4.2%, 2.1%]	5

Footnotes

1. the arithmetic mean of the percent change ↩ ↩² ↩³

2. number of relevant changes ↩ ↩² ↩³

[the8472]

Addresses the regression in #101620

Not fully. E.g. the worst-case max-rss regression in ucd | check | incr-unchanged is 28%, which isn't recovered by this PR.

[Mark-Simulacrum]

And on instruction counts too - this is the contributor to the big jump in the week summary graphs, which doesn't recover by the end of the week pretty much at all.

[Mark-Simulacrum]

@cjgillot I think #101839 should be landed until we have a PR that actually restores our performance here to baseline, which this PR didn't do. (Or some discussion should be had about why we're taking a fairly large hit across many benchmarks, including primary ones).