Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert perf-regression 101620 #102064

Merged
merged 2 commits into from
Sep 24, 2022
Merged

Revert perf-regression 101620 #102064

merged 2 commits into from
Sep 24, 2022

Conversation

cjgillot
Copy link
Contributor

@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 20, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 20, 2022
@cjgillot cjgillot marked this pull request as ready for review September 20, 2022 18:07
@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 20, 2022
@bors
Copy link
Contributor

bors commented Sep 20, 2022

⌛ Trying commit a4708ad24676f7d384f2188ddd905717f58acd16 with merge 4ed50b77a11b5371d2119b3a7fb491f7006f95b1...

@bors
Copy link
Contributor

bors commented Sep 20, 2022

☀️ Try build successful - checks-actions
Build commit: 4ed50b77a11b5371d2119b3a7fb491f7006f95b1 (4ed50b77a11b5371d2119b3a7fb491f7006f95b1)

@rust-timer
Copy link
Collaborator

Queued 4ed50b77a11b5371d2119b3a7fb491f7006f95b1 with parent cd8cc91, future comparison URL.

@cjgillot cjgillot changed the title Revert pref-regression 101620 Revert perf-regression 101620 Sep 20, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (4ed50b77a11b5371d2119b3a7fb491f7006f95b1): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 5.5% [0.3%, 33.5%] 34
Regressions ❌
(secondary)		 1.2% [0.3%, 1.8%] 13
Improvements ✅
(primary)		 -3.7% [-12.5%, -0.3%] 126
Improvements ✅
(secondary)		 -4.1% [-19.1%, -0.1%] 122
All ❌✅ (primary) -1.8% [-12.5%, 33.5%] 160

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 4.3% [0.8%, 10.9%] 13
Regressions ❌
(secondary)		 3.0% [3.0%, 3.0%] 2
Improvements ✅
(primary)		 -4.2% [-12.9%, -1.1%] 105
Improvements ✅
(secondary)		 -7.6% [-22.2%, -1.2%] 66
All ❌✅ (primary) -3.3% [-12.9%, 10.9%] 118

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 14.3% [2.7%, 45.0%] 19
Regressions ❌
(secondary)		 3.8% [2.5%, 5.6%] 5
Improvements ✅
(primary)		 -4.8% [-13.7%, -1.2%] 82
Improvements ✅
(secondary)		 -8.7% [-24.1%, -2.0%] 60
All ❌✅ (primary) -1.2% [-13.7%, 45.0%] 101

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2 ↩3

  2. number of relevant changes ↩ ↩2 ↩3

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Sep 20, 2022
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Sep 22, 2022 •
edited
Loading

r=me, I guess needs a rebase.

Regressions are expected (we're reverting a PR that did improve performance on a subset of benchmarks) but overall the regressions there and the improvements here outweigh each other -- we see a 1.8% improvement in the primary benchmarks overall.

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. perf-regression-triaged The performance regression has been triaged. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2022
@cjgillot
Copy link
Contributor Author

@bors r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Sep 22, 2022

📌 Commit 3916434619d06e5eb00df021c9873adfe419b263 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 22, 2022
@cjgillot
Revert "Auto merge of rust-lang#101862 - cjgillot:lint-regression, r=…
381bd2a 
…oli-obk"

This reverts commit bc7b17c, reversing
changes made to 5253b0a.
@cjgillot
Revert "Auto merge of rust-lang#101620 - cjgillot:compute_lint_levels…
fc43df0 
…_by_def, r=oli-obk"

This reverts commit 2cb9a65, reversing
changes made to 750bd1a.
@cjgillot
Copy link
Contributor Author

@bors r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Sep 22, 2022

📌 Commit fc43df0 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 24, 2022
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@cjgillot
Copy link
Contributor Author

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 24, 2022
@bors
Copy link
Contributor

bors commented Sep 24, 2022

⌛ Testing commit fc43df0 with merge bb5a016...

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Contributor

bors commented Sep 24, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing bb5a016 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 24, 2022
@bors bors merged commit bb5a016 into rust-lang:master Sep 24, 2022
@rustbot rustbot added this to the 1.66.0 milestone Sep 24, 2022
@bors bors mentioned this pull request Sep 24, 2022
Merged
@cjgillot cjgillot deleted the revert branch September 24, 2022 12:46
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (bb5a016): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 5.6% [0.3%, 33.5%] 33
Regressions ❌
(secondary)		 1.1% [0.3%, 1.5%] 11
Improvements ✅
(primary)		 -3.7% [-12.3%, -0.3%] 129
Improvements ✅
(secondary)		 -4.1% [-19.0%, -0.2%] 121
All ❌✅ (primary) -1.8% [-12.3%, 33.5%] 162

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 3.6% [1.1%, 10.2%] 17
Regressions ❌
(secondary)		 2.5% [2.1%, 3.1%] 3
Improvements ✅
(primary)		 -4.2% [-13.0%, -0.9%] 100
Improvements ✅
(secondary)		 -8.0% [-22.1%, -1.5%] 60
All ❌✅ (primary) -3.0% [-13.0%, 10.2%] 117

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 15.4% [2.6%, 42.8%] 17
Regressions ❌
(secondary)		 2.9% [2.9%, 2.9%] 1
Improvements ✅
(primary)		 -4.8% [-13.4%, -1.4%] 89
Improvements ✅
(secondary)		 -9.4% [-24.6%, -2.3%] 56
All ❌✅ (primary) -1.6% [-13.4%, 42.8%] 106

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2 ↩3

  2. number of relevant changes ↩ ↩2 ↩3

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

oli-obk pushed a commit to oli-obk/rust that referenced this pull request Sep 28, 2022
@bors
Auto merge of rust-lang#102064 - cjgillot:revert, r=Mark-Simulacrum
4889c17 
Revert perf-regression 101620

Reverts rust-lang#101862 rust-lang#101620

r? `@Mark-Simulacrum`
@cjgillot cjgillot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 1, 2022
@cjgillot
Copy link
Contributor Author

cjgillot commented Oct 1, 2022

The regression slipped into beta. I think this PR deserves consideration for backport.

@rust-lang rust-lang deleted a comment Oct 2, 2022
@apiraino
Copy link
Contributor

apiraino commented Oct 6, 2022

Beta backport accepted as per compiler team on Zulip

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Oct 6, 2022
@cuviper cuviper mentioned this pull request Oct 6, 2022
Merged
@cuviper
Copy link
Member

cuviper commented Oct 6, 2022

Reverts #101862 #101620

#101862 did not reach beta, so I've only cherry-picked the commit to revert #101620.

@cuviper cuviper modified the milestones: 1.66.0, 1.65.0 Oct 6, 2022
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 6, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 10, 2022
@bors
Auto merge of rust-lang#102676 - cuviper:beta-next, r=cuviper
da7ffa2 
[beta] backports

* Avoid duplicating StorageLive in let-else rust-lang#101894
* Re-add HRTB implied static bug note rust-lang#101924
* Revert "Copy stage0 binaries into stage0-sysroot" rust-lang#101942
* implied_bounds: deal with inference vars rust-lang#102016
* fix ConstProp handling of written_only_inside_own_block_locals rust-lang#102045
* Fix wrongly refactored Lift impl rust-lang#102088
* Fix a typo “pararmeter” in error message rust-lang#102119
* Deny associated type bindings within associated type bindings rust-lang#102338
* Continue migration of CSS themes rust-lang#101934
* Fix search result colors rust-lang#102369
* Fix unwind drop glue for if-then scopes rust-lang#102394
* Revert "Use getentropy when possible on all Apple platforms" rust-lang#102693
* Fix associated type bindings with anon const in GAT position rust-lang#102336
* Revert perf-regression 101620 rust-lang#102064
* `EscapeAscii` is not an `ExactSizeIterator` rust-lang#99880
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@bors
Auto merge of rust-lang#102064 - cjgillot:revert, r=Mark-Simulacrum
93e726b 
Revert perf-regression 101620

Reverts rust-lang#101862 rust-lang#101620

r? `@Mark-Simulacrum`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.
10 participants
@cjgillot @rust-timer @bors @Mark-Simulacrum @lqd @rust-log-analyzer @apiraino @cuviper @rust-highfive @rustbot