Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrongly refactored Lift impl #102088

Merged
merged 1 commit into from
Sep 24, 2022
Merged

Fix wrongly refactored Lift impl #102088

merged 1 commit into from
Sep 24, 2022

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Sep 21, 2022

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 21, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 21, 2022
@bjorn3
Copy link
Member

bjorn3 commented Sep 21, 2022

I've confirmed this fixes my problem.

@bors r+

@bors
Copy link
Contributor

bors commented Sep 21, 2022

📌 Commit 3e6c9e5 has been approved by bjorn3

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 21, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 23, 2022
@matthiaskrgr
Rollup merge of rust-lang#102088 - oli-obk:cleanups, r=bjorn3
a69855c 
Fix wrongly refactored Lift impl

see rust-lang#101858 (comment)

r? `@bjorn3`
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 23, 2022
Closed
@wesleywiser
Copy link
Member

#101858 made the beta cut. Should we nominate this for backport?

@oli-obk oli-obk added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Sep 23, 2022
@oli-obk
Copy link
Contributor Author

oli-obk commented Sep 23, 2022

yea, I can't figure out how to reproduce on master from user code, but still better safe than sorry.

@wesleywiser
Copy link
Member

I don't see an urgent reason to beta-accept this ASAP so I'll switch the label to beta-nominated for discussion at next week's triage meeting.

@wesleywiser wesleywiser added beta-nominated Nominated for backporting to the compiler in the beta channel. and removed beta-accepted Accepted for backporting to the compiler in the beta channel. labels Sep 23, 2022
@oli-obk
Copy link
Contributor Author

oli-obk commented Sep 23, 2022

Eh, wrong label selected... I meant to nominate

Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 24, 2022
@Dylan-DPC
Rollup merge of rust-lang#102088 - oli-obk:cleanups, r=bjorn3
6a92d4e 
Fix wrongly refactored Lift impl

see rust-lang#101858 (comment)

r? `@bjorn3`
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 24, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 24, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 24, 2022
@bors
Auto merge of rust-lang#102234 - matthiaskrgr:rollup-5cb20l1, r=matth…
6580010 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#100823 (Refactor some `std` code that works with pointer offstes)
 - rust-lang#102088 (Fix wrongly refactored Lift impl)
 - rust-lang#102109 (resolve: Set effective visibilities for imports more precisely)
 - rust-lang#102186 (Add const_closure, Constify Try trait)
 - rust-lang#102203 (rustdoc: remove no-op CSS `#source-sidebar { z-index }`)
 - rust-lang#102204 (Make `ManuallyDrop` satisfy `~const Destruct`)
 - rust-lang#102210 (diagnostics: avoid syntactically invalid suggestion in if conditionals)
 - rust-lang#102226 (bootstrap/miri: switch to non-deprecated env var for setting the sysroot folder)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bf167e0 into rust-lang:master Sep 24, 2022
@rustbot rustbot added this to the 1.66.0 milestone Sep 24, 2022
@apiraino
Copy link
Contributor

Beta backport accepted as per compiler team on Zulip

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Sep 29, 2022
@oli-obk oli-obk deleted the cleanups branch September 29, 2022 14:22
@cuviper cuviper mentioned this pull request Oct 4, 2022
Merged
@cuviper cuviper modified the milestones: 1.66.0, 1.65.0 Oct 4, 2022
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 4, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 10, 2022
@bors
Auto merge of rust-lang#102676 - cuviper:beta-next, r=cuviper
da7ffa2 
[beta] backports

* Avoid duplicating StorageLive in let-else rust-lang#101894
* Re-add HRTB implied static bug note rust-lang#101924
* Revert "Copy stage0 binaries into stage0-sysroot" rust-lang#101942
* implied_bounds: deal with inference vars rust-lang#102016
* fix ConstProp handling of written_only_inside_own_block_locals rust-lang#102045
* Fix wrongly refactored Lift impl rust-lang#102088
* Fix a typo “pararmeter” in error message rust-lang#102119
* Deny associated type bindings within associated type bindings rust-lang#102338
* Continue migration of CSS themes rust-lang#101934
* Fix search result colors rust-lang#102369
* Fix unwind drop glue for if-then scopes rust-lang#102394
* Revert "Use getentropy when possible on all Apple platforms" rust-lang#102693
* Fix associated type bindings with anon const in GAT position rust-lang#102336
* Revert perf-regression 101620 rust-lang#102064
* `EscapeAscii` is not an `ExactSizeIterator` rust-lang#99880
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bjorn3 bjorn3

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.
8 participants
@oli-obk @bjorn3 @bors @wesleywiser @apiraino @cuviper @rust-highfive @rustbot