Fix a typo “pararmeter” in error message #102119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @fee1-dead (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
dtolnay
approved these changes
Sep 22, 2022
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Sep 22, 2022
Fix a typo “pararmeter” in error message Issue reported on IRLO: https://internals.rust-lang.org/t/fixing-a-typo/17427
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 22, 2022
Rollup of 8 pull requests Successful merges: - rust-lang#101598 (Update rustc's information on Android's sanitizers) - rust-lang#102036 (Remove use of `io::ErrorKind::Other` in std) - rust-lang#102037 (Make cycle errors recoverable) - rust-lang#102069 (Skip `Equate` relation in `handle_opaque_type`) - rust-lang#102076 (rustc_transmute: fix big-endian discriminants) - rust-lang#102107 (Add missing space between notable trait tooltip and where clause) - rust-lang#102119 (Fix a typo “pararmeter” in error message) - rust-lang#102131 (Added which number is computed in compute_float.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
IMO such a typo in error messages seems kinda embarrassing. Is it too unusual to beta-backport such a fix? I mean it's a "regression" in that a typo-free error message got (a new part containing) a typo added. (And also the fix is essentially zero risk.) |
|
@steffahn in t-compiler we tend to gauge three things: how likely someone is to see the problem, how disastrous the problem is, and how complex the solution being backported would be. I'd be comfortable backporting. |
estebank
added
the
beta-nominated
rustbot
added
the
beta-accepted
Merged
cuviper
removed
the
beta-nominated
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 10, 2022
[beta] backports * Avoid duplicating StorageLive in let-else rust-lang#101894 * Re-add HRTB implied static bug note rust-lang#101924 * Revert "Copy stage0 binaries into stage0-sysroot" rust-lang#101942 * implied_bounds: deal with inference vars rust-lang#102016 * fix ConstProp handling of written_only_inside_own_block_locals rust-lang#102045 * Fix wrongly refactored Lift impl rust-lang#102088 * Fix a typo “pararmeter” in error message rust-lang#102119 * Deny associated type bindings within associated type bindings rust-lang#102338 * Continue migration of CSS themes rust-lang#101934 * Fix search result colors rust-lang#102369 * Fix unwind drop glue for if-then scopes rust-lang#102394 * Revert "Use getentropy when possible on all Apple platforms" rust-lang#102693 * Fix associated type bindings with anon const in GAT position rust-lang#102336 * Revert perf-regression 101620 rust-lang#102064 * `EscapeAscii` is not an `ExactSizeIterator` rust-lang#99880
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue reported on IRLO: https://internals.rust-lang.org/t/fixing-a-typo/17427