Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for custom mir #103464

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Add support for custom mir #103464

merged 1 commit into from
Nov 10, 2022

Conversation

JakobDegen
Copy link
Contributor

@JakobDegen JakobDegen commented Oct 24, 2022 •
edited
Loading

This implements rust-lang/compiler-team#564 . Details about the design, motivation, etc. can be found in there.

r? @oli-obk

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 24, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 24, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Oct 24, 2022

I don't know if this needs an MCP. I can put one up if necessary.

Please do, even if we just use it as an announcement

@JakobDegen
Copy link
Contributor Author

I'll put one up later today. I'll squash all three commits in the branch then though, will be a little bit harder to review but will more accurately represent the MVP.

@JakobDegen JakobDegen mentioned this pull request Oct 25, 2022
Closed
3 tasks
@JakobDegen
Copy link
Contributor Author

Squashed commits and MCP is up

@JakobDegen
Copy link
Contributor Author

First commit is gone since that PR merged. Marking as ready since I have no more changes planned to this PR, still might want to wait for the FCP to finish though

@JakobDegen JakobDegen marked this pull request as ready for review October 26, 2022 21:45
@rustbot
Copy link
Collaborator

rustbot commented Oct 26, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@JakobDegen JakobDegen mentioned this pull request Nov 2, 2022
Merged
15 tasks
@oli-obk
Copy link
Contributor

oli-obk commented Nov 8, 2022

@bors r+ 🚀

@bors
Copy link
Contributor

bors commented Nov 8, 2022

📌 Commit a2f3649 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 8, 2022
Manishearth added a commit to Manishearth/rust that referenced this pull request Nov 8, 2022
@Manishearth
Rollup merge of rust-lang#103464 - JakobDegen:mir-parsing, r=oli-obk
eac2f83 
Add support for custom mir

This implements rust-lang/compiler-team#564 . Details about the design, motivation, etc. can be found in there.

r? `@oli-obk`
@Manishearth Manishearth mentioned this pull request Nov 8, 2022
Closed
@matthiaskrgr
Copy link
Member

@bors r-
looks like this failed in a rollup: #104167
https://github.com/rust-lang/rust/actions/runs/3422647986/jobs/5700299869#step:25:1577

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 8, 2022
@JakobDegen
Copy link
Contributor Author

Semantic conflict with my own change, will rebase and fix later today

@JakobDegen
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 9, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Nov 9, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Nov 9, 2022

📌 Commit ba359d8 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 9, 2022
Manishearth added a commit to Manishearth/rust that referenced this pull request Nov 9, 2022
@Manishearth
Rollup merge of rust-lang#103464 - JakobDegen:mir-parsing, r=oli-obk
25be18b 
Add support for custom mir

This implements rust-lang/compiler-team#564 . Details about the design, motivation, etc. can be found in there.

r? `@oli-obk`
@Manishearth Manishearth mentioned this pull request Nov 9, 2022
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Nov 9, 2022
@Manishearth
Rollup merge of rust-lang#103464 - JakobDegen:mir-parsing, r=oli-obk
7b4018a 
Add support for custom mir

This implements rust-lang/compiler-team#564 . Details about the design, motivation, etc. can be found in there.

r? ``@oli-obk``
@Manishearth Manishearth mentioned this pull request Nov 9, 2022
Closed
@Manishearth Manishearth mentioned this pull request Nov 9, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 9, 2022
@bors
Auto merge of rust-lang#104215 - Manishearth:rollup-5r957ad, r=Manish…
34115d0 
…earth

Rollup of 9 pull requests

Successful merges:

 - rust-lang#101005 (Migrate rustc_codegen_llvm to SessionDiagnostics)
 - rust-lang#103307 (Add context to compiler error message)
 - rust-lang#103464 (Add support for custom mir)
 - rust-lang#103929 (Cleanup Apple-related code in rustc_target)
 - rust-lang#104015 (Remove linuxkernel targets)
 - rust-lang#104020 (Limit efiapi calling convention to supported arches)
 - rust-lang#104156 (Cleanups in autoderef impl)
 - rust-lang#104171 (Update books)
 - rust-lang#104184 (Fix `rustdoc --version` when used with download-rustc)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3f11d39 into rust-lang:master Nov 10, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 10, 2022
@JakobDegen JakobDegen deleted the mir-parsing branch November 10, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
6 participants
@JakobDegen @oli-obk @rustbot @bors @matthiaskrgr @rust-highfive