-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 9 pull requests #104208
Closed
Closed
Rollup of 9 pull requests #104208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed `creates a temporary which is freed while still in use` to `creates a temporary value which is freed while still in use`
These are not used by the actual Rust-for-Linux project, so they're mostly just confusing.
…dant with the main span
Previously, rustdoc would unconditionally report the version that *rustc* was compiled with. That showed things like `nightly-2022-10-30`, which wasn't right, since this was a `dev` build compiled from source. Fix it by changing `rustc_driver::version` to a macro expanded at invocation time.
Co-authored-by: David Wood <agile.lion3441@fuligin.ink>
…nostics, r=davidtwco Migrate rustc_codegen_llvm to SessionDiagnostics WIP: Port current implementation of diagnostics to the new SessionDiagnostics. Part of rust-lang#100717 ``@rustbot`` label +A-translation
Add context to compiler error message Changed `creates a temporary which is freed while still in use` to `creates a temporary value which is freed while still in use`.
Add support for custom mir This implements rust-lang/compiler-team#564 . Details about the design, motivation, etc. can be found in there. r? ``@oli-obk``
…, r=petrochenkov Cleanup Apple-related code in rustc_target While working on rust-lang#103455, the consistency of the `rustc_target` code for Apple's platforms was "kind of bad." There were two "base" files (`apple_base.rs` and `apple_sdk_base.rs`) that the targets each pulled some parts out of, each and all of them were written slightly differently, and sometimes missed comments other implementations had. So to hopefully make future maintenance, like implementing rust-lang/compiler-team#556, easier, this makes all of them use similar patterns and the same target base logic everywhere instead of picking bits from both. This also has some other smaller upsides like less stringly-typed functions.
Remove linuxkernel targets These are not used by the actual Rust-for-Linux project, so they're mostly just confusing.
…ble-trait, r=GuillaumeGomez rustdoc: use javascript to layout notable traits popups Fixes rust-lang#102576 Preview: https://notriddle.com/notriddle-rustdoc-demos/102576-js-notable-trait/std/iter/trait.Iterator.html#method.step_by ## Before ![image](https://user-images.githubusercontent.com/1593513/200432713-23aa8d49-ba2b-469f-9eab-089e0c174039.png) ## After ![image](https://user-images.githubusercontent.com/1593513/200432735-edd5b53d-e99d-4fc5-9410-8a79e0efdc9d.png)
Cleanups in autoderef impl Just something I noticed. Turns out the `overloaded_span` is not actually used separately from the main span, so I merged them.
Update books ## nomicon 1 commits in 9c73283775466d22208a0b28afcab44db4c0cc10..05532356e7a4dbea2330aabb77611f5179493bb8 2022-09-30 07:31:22 +0900 to 2022-11-05 08:13:14 +0900 - Fix typos and grammatical errors (rust-lang/nomicon#384) ## reference 1 commits in 4ea7c5def38ac81df33a9e48e5637a82a5ac404d..9f0cc13ffcd27c1fbe1ab766a9491e15ddcf4d19 2022-10-25 15:14:36 -0700 to 2022-10-31 04:09:16 -0700 - Add a comma (rust-lang/reference#1289) ## book 12 commits in aa5ee485bd6bd80d205da7c82fcdd776f92fdd51..3f64052c048c6def93b94a2b514ee88bba918744 2022-10-20 16:49:55 -0400 to 2022-11-03 22:13:58 -0400 - Upgrade to Rust 1.65 - Upgrade to Rust 1.64 - Upgrade to Rust 1.63 - New ideas for the issue template to try - Clarify that the conditional expression is the one under discussion - Updates from copyedit of ch6 - Made Option<T> error explanation more clear - Update ch06-01-defining-an-enum - Upgrade mdbook - Clarify that user1 can't be used as a whole instance. Fixes rust-lang/book#2978. - Fix plural and incorrect phrase. Fixes rust-lang/book#3359. - Updates from copyedit of ch5 ## rust-by-example 4 commits in 03491f33375c5a2a1661c7fa4be671fe95ce1249..2b15c0abf2bada6e00553814336bc3e2d8399097 2022-10-21 07:30:08 -0300 to 2022-10-31 08:30:13 -0300 - Remove --edition from src/crates/using_lib.md (rust-lang/rust-by-example#1635) - upgrade upload-artifact - Clarify Fn in fn/closures/input_parameters.md (rust-lang/rust-by-example#1634) - fix: erroneous white spaces in types/cast.md ## rustc-dev-guide 12 commits in 51a37ad19a15709d0601afbac6581f5aea6a45da..d0dc6c97a6486f68bac782fff135086eae6d77ec 2022-10-25 10:18:58 -0700 to 2022-11-07 16:49:22 +0200 - trans -> codegen - Remove implementation details - Update some more things and improve wording - Update query.md - replace tabs with spaces (rust-lang/rustc-dev-guide#1504) - align code blocks with their paragraphs - Fixes some typos (rust-lang/rustc-dev-guide#1502) - UPDATE - mention of Diagnostic derive on enums - trans -> codegen (rust-lang/rustc-dev-guide#1500) - add note for err annotation formatting - Remove `--bless` from pre-push hook suggestion - Update for highfive transition.
Fix `rustdoc --version` when used with download-rustc Previously, rustdoc would unconditionally report the version that *rustc* was compiled with. That showed things like `nightly-2022-10-30`, which wasn't right, since this was a `dev` build compiled from source. Fix it by changing `rustc_driver::version` to a macro expanded at invocation time. cc rust-lang#103206 (comment)
rustbot
added
A-translation
Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
rollup
A PR which is a rollup
labels
Nov 9, 2022
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 9, 2022
⌛ Testing commit 4293f9a with merge a0ba21339dcb87d97eb81b10d8ef640802bdc983... |
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Nov 9, 2022
The job Click to see the possible cause of the failure (guessed by this bot)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-translation
Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic
rollup
A PR which is a rollup
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
rustdoc --version
when used with download-rustc #104184 (Fixrustdoc --version
when used with download-rustc)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup