Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interpret: remove PartialOrd from a bunch of types that do not have or need a sensible order #104933

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

RalfJung
Copy link
Member

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 26, 2022
@rustbot
Copy link
Collaborator

rustbot commented Nov 26, 2022

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

The Miri subtree was changed

cc @rust-lang/miri

@oli-obk
Copy link
Contributor

oli-obk commented Nov 28, 2022

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 28, 2022

📌 Commit 77071f7 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 28, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 28, 2022
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#104804 (Rename `ast::Lit` as `ast::MetaItemLit`.)
 - rust-lang#104891 (Add documentation for `has_escaping_bound_vars`)
 - rust-lang#104933 (interpret: remove PartialOrd from a bunch of types that do not have or need a sensible order)
 - rust-lang#104936 (Ignore bivariant parameters in test_type_match.)
 - rust-lang#104954 (make simple check of prinf function)
 - rust-lang#104956 (Avoid ICE if the Clone trait is not found while building error suggestions)
 - rust-lang#104982 (interpret: get rid of run() function)
 - rust-lang#104998 (Update my mailmap)
 - rust-lang#105006 (stricter alignment enforcement for ScalarPair)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9a96a6d into rust-lang:master Nov 28, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 28, 2022
@leonardo-m
Copy link

It could be nice to have a Clippy on-demand lint to spot "useless" trait bounds.

@RalfJung RalfJung deleted the interpret-partial-ord branch December 2, 2022 11:11
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
…oli-obk

interpret: remove PartialOrd from a bunch of types that do not have or need a sensible order

r? `@oli-obk`
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#104804 (Rename `ast::Lit` as `ast::MetaItemLit`.)
 - rust-lang#104891 (Add documentation for `has_escaping_bound_vars`)
 - rust-lang#104933 (interpret: remove PartialOrd from a bunch of types that do not have or need a sensible order)
 - rust-lang#104936 (Ignore bivariant parameters in test_type_match.)
 - rust-lang#104954 (make simple check of prinf function)
 - rust-lang#104956 (Avoid ICE if the Clone trait is not found while building error suggestions)
 - rust-lang#104982 (interpret: get rid of run() function)
 - rust-lang#104998 (Update my mailmap)
 - rust-lang#105006 (stricter alignment enforcement for ScalarPair)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants