Rollup of 9 pull requests #105017

matthiaskrgr · 2022-11-28T16:25:51Z

Successful merges:

Rename ast::Lit as ast::MetaItemLit. #104804 (Rename ast::Lit as ast::MetaItemLit.)
Add documentation for has_escaping_bound_vars #104891 (Add documentation for has_escaping_bound_vars)
interpret: remove PartialOrd from a bunch of types that do not have or need a sensible order #104933 (interpret: remove PartialOrd from a bunch of types that do not have or need a sensible order)
Ignore bivariant parameters in test_type_match. #104936 (Ignore bivariant parameters in test_type_match.)
make simple check of prinf function #104954 (make simple check of prinf function)
Avoid ICE if the Clone trait is not found while building error suggestions #104956 (Avoid ICE if the Clone trait is not found while building error suggestions)
interpret: get rid of run() function #104982 (interpret: get rid of run() function)
Update my mailmap #104998 (Update my mailmap)
stricter alignment enforcement for ScalarPair and Vector #105006 (stricter alignment enforcement for ScalarPair)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

…r need a sensible order

With this commit we start to make some simple check when the name resolution fails, and we generate some helper message in case the name is a C name like in the case of the `printf` and suggest the correct rust method. Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

…tions

`Lit::from_included_bytes` calls `Lit::from_lit_kind`, but the two call sites only need the resulting `token::Lit`, not the full `ast::Lit`. This commit changes those call sites to use `LitKind::to_token_lit`, which means `from_included_bytes` can be removed.

We already use a mix of `Literal` and `Lit`. The latter is better because it is shorter without causing any ambiguity.

…enkov Rename `ast::Lit` as `ast::MetaItemLit`. And some other literal cleanups. r? `@petrochenkov`

…ars_docs, r=wesleywiser Add documentation for `has_escaping_bound_vars` Thanks to `@BoxyUwU` for explaining this to me. Adding docs with a helpful link if people get confused.

…oli-obk interpret: remove PartialOrd from a bunch of types that do not have or need a sensible order r? `@oli-obk`

…-obk Ignore bivariant parameters in test_type_match. rust-lang#103491 made opaque types bivariant with respect of some of their lifetime parameters. Because of this bivariance, some lifetime variables were not unified to anything during borrowck, and were considered as unequal by borrowck type test. This PR makes type test ignore the bivariant parameters in test_type_match. Fixes rust-lang#104815 r? `@oli-obk`

…tebank make simple check of prinf function Fixes rust-lang#92898 With this commit we start to make some simple check when the name resolution fails, and we generate some helper messages in case the name is a C name like in the case of the `printf` and suggest the correct rust method. `@rustbot` r? `@pnkfelix` Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

…errors Avoid ICE if the Clone trait is not found while building error suggestions Fixes rust-lang#104870 r? `@compiler-errors`

interpret: get rid of run() function Miri needs its own loop anyway, so there's not much of a point in trying to share this code.

Update my mailmap

…eddyb stricter alignment enforcement for ScalarPair `@eddyb` [indicated](rust-lang#103926 (comment)) that alignment violating this check might be a bug. So let's see what the test suite says. (Only the 2nd commit actually changes behavior... but I couldn't not do that other cleanup.^^) Does the PR CI runner even enable debug assertions though...?

matthiaskrgr · 2022-11-28T16:26:15Z

@bors r+ rollup=never p=9

bors · 2022-11-28T16:26:17Z

📌 Commit 3dfb6ca has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2022-11-28T20:53:52Z

⌛ Testing commit 3dfb6ca with merge 2585bce...

bors · 2022-11-28T23:45:08Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 2585bce to master...

rust-timer · 2022-11-28T23:47:41Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#105006	10c6f380cc0d68daa27faa195d16cea9b13b1957
#104998	4894b7e72d051df833b52a594498e8b33ebf72c0
#104982	618be53dbcb77dd44403b144e69c0dfdf4b90cda
#104956	b8b51f037e5325221bae7c4e1b7230bdcf7fc6a6
#104954	84ed39a7f26c86abd9f583bfffb88a656186735d
#104936	1d848d30b50577c6c9cc38891eb1b7f1f2c5e8c1
#104933	1c539acfa961809e38cf199a25c1b35bbd99d28f
#104891	3b7bc2f5e512df7923011a626bfc26e664406564
#104804	cd5fbf42683c4415b05de659488295f97642a7e9

previous master: 8a09420ac4

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2022-11-29T13:47:10Z

Finished benchmarking commit (2585bce): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.9%	[0.9%, 1.0%]	2
Regressions ❌ (secondary)	3.7%	[2.2%, 5.6%]	12
Improvements ✅ (primary)	-0.6%	[-0.8%, -0.4%]	7
Improvements ✅ (secondary)	-1.1%	[-1.3%, -0.9%]	4
All ❌✅ (primary)	-0.3%	[-0.8%, 1.0%]	9

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	6.1%	[3.2%, 9.0%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.0%	[2.6%, 3.7%]	7
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

lqd · 2022-11-29T15:17:38Z

I think this is likely noise, as we mostly see the inverse of #105008.

Here's cranelift for example by now, this PR is the first point getting back to the baseline.

ctfe-stress-5 may be real, but it's only a secondary benchmark

nnethercote · 2022-11-29T21:37:16Z

I agree that the keccak, cranelift-codegen and bitmaps changes are noise, but the ~5% ctfe-stress-5 regressions look genuine.

nnethercote · 2022-11-29T21:58:35Z

@rust-timer build 10c6f380cc0d68daa27faa195d16cea9b13b1957

rust-timer · 2022-11-30T01:42:55Z

Finished benchmarking commit (10c6f380cc0d68daa27faa195d16cea9b13b1957): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.9%	[0.8%, 0.9%]	2
Regressions ❌ (secondary)	2.4%	[2.2%, 2.8%]	6
Improvements ✅ (primary)	-0.6%	[-0.9%, -0.5%]	7
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.3%	[-0.9%, 0.9%]	9

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.2%	[2.9%, 3.6%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

nnethercote · 2022-12-01T03:34:19Z

These changes are all noise.

@rustbot label: +perf-regression-triaged

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#104804 (Rename `ast::Lit` as `ast::MetaItemLit`.) - rust-lang#104891 (Add documentation for `has_escaping_bound_vars`) - rust-lang#104933 (interpret: remove PartialOrd from a bunch of types that do not have or need a sensible order) - rust-lang#104936 (Ignore bivariant parameters in test_type_match.) - rust-lang#104954 (make simple check of prinf function) - rust-lang#104956 (Avoid ICE if the Clone trait is not found while building error suggestions) - rust-lang#104982 (interpret: get rid of run() function) - rust-lang#104998 (Update my mailmap) - rust-lang#105006 (stricter alignment enforcement for ScalarPair) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

fee1-dead and others added 23 commits November 25, 2022 15:02

Add documentation for has_escaping_bound_vars

815d370

interpret: remove PartialOrd from a bunch of types that do not have o…

77071f7

…r need a sensible order

Ignore bivariant parameters in test_type_match.

89afda7

interpret: get rid of run() function

60d5d65

Update my mailmap

bb273a1

Avoid ICE if the Clone trait is not found while building error sugges…

7a378dd

…tions

Factor out a repeated expression in lower_attr_args.

aa10aad

Rename ast::Lit as ast::MetaItemLit.

e4a9150

Adjust comments on StrLit.

1c65264

Rename NestedMetaItem::[Ll]iteral as NestedMetaItem::[Ll]it.

a60e337

We already use a mix of `Literal` and `Lit`. The latter is better because it is shorter without causing any ambiguity.

sanity_check_layout: less rightwards drift

58dd62a

stricter alignment enforcement for ScalarPair and Vector

891a4da

Rollup merge of rust-lang#104804 - nnethercote:MetaItemLit, r=petroch…

63ec33e

…enkov Rename `ast::Lit` as `ast::MetaItemLit`. And some other literal cleanups. r? `@petrochenkov`

Rollup merge of rust-lang#104891 - fee1-dead-contrib:escaping_bound_v…

069f219

…ars_docs, r=wesleywiser Add documentation for `has_escaping_bound_vars` Thanks to `@BoxyUwU` for explaining this to me. Adding docs with a helpful link if people get confused.

Rollup merge of rust-lang#104933 - RalfJung:interpret-partial-ord, r=…

9a96a6d

…oli-obk interpret: remove PartialOrd from a bunch of types that do not have or need a sensible order r? `@oli-obk`

Rollup merge of rust-lang#104956 - mucinoab:issue-104870, r=compiler-…

db2850c

…errors Avoid ICE if the Clone trait is not found while building error suggestions Fixes rust-lang#104870 r? `@compiler-errors`

Rollup merge of rust-lang#104982 - RalfJung:norun, r=oli-obk

3aace9a

interpret: get rid of run() function Miri needs its own loop anyway, so there's not much of a point in trying to share this code.

Rollup merge of rust-lang#104998 - JakobDegen:mailmap, r=jyn514

95de06b

Update my mailmap

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 28, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 28, 2022

bors merged commit 2585bce into rust-lang:master Nov 28, 2022

rustbot added this to the 1.67.0 milestone Nov 28, 2022

This was referenced Nov 29, 2022

errors: generate typed identifiers in each crate #103042

Merged

Attribute cleanups #104861

Merged

rustbot added the perf-regression Performance regression. label Nov 29, 2022

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 30, 2022

rustbot added the perf-regression-triaged The performance regression has been triaged. label Dec 1, 2022

matthiaskrgr deleted the rollup-j0x550l branch December 22, 2022 10:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 9 pull requests #105017

Rollup of 9 pull requests #105017

matthiaskrgr commented Nov 28, 2022

matthiaskrgr commented Nov 28, 2022

bors commented Nov 28, 2022

bors commented Nov 28, 2022

bors commented Nov 28, 2022

rust-timer commented Nov 28, 2022

rust-timer commented Nov 29, 2022

lqd commented Nov 29, 2022 •

edited

Loading

nnethercote commented Nov 29, 2022

nnethercote commented Nov 29, 2022

This comment has been minimized.

rust-timer commented Nov 30, 2022

nnethercote commented Dec 1, 2022

Rollup of 9 pull requests #105017

Rollup of 9 pull requests #105017

Conversation

matthiaskrgr commented Nov 28, 2022

matthiaskrgr commented Nov 28, 2022

bors commented Nov 28, 2022

bors commented Nov 28, 2022

bors commented Nov 28, 2022

rust-timer commented Nov 28, 2022

rust-timer commented Nov 29, 2022

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

lqd commented Nov 29, 2022 • edited Loading

nnethercote commented Nov 29, 2022

nnethercote commented Nov 29, 2022

This comment has been minimized.

rust-timer commented Nov 30, 2022

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

nnethercote commented Dec 1, 2022

lqd commented Nov 29, 2022 •

edited

Loading