Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #105122

Closed
wants to merge 16 commits into from
Closed

Commits on Nov 28, 2022

  1. Run Windows-only tests only on Windows

    This removes the need to maintain a list of all other
    OSs which ignore the tests.
    flba-eb committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    3e72a01 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2022

  1. Configuration menu
    Copy the full SHA
    a982541 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7578100 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    52ce1f7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5a34dbf View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    97f0c58 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    02eaecc View commit details
    Browse the repository at this point in the history
  7. rustdoc: remove redundant CSS div.desc { display: block }

    DIV tags have block display by default. It is from when this rule
    used to target a SPAN tag, but became redundant in
    4bd6748.
    notriddle committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    2405e60 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    56126fb View commit details
    Browse the repository at this point in the history
  9. Fix ICE from rust-lang#105101

    jhpratt committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    ab264ae View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2022

  1. Rollup merge of rust-lang#104975 - JakobDegen:custom_mir_let, r=oli-obk

    `#![custom_mir]`: Various improvements
    
    This PR makes a bunch of improvements to `#![custom_mir]`. Ideally this would be 4 PRs, one for each commit, but those would take forever to get merged and be a pain to juggle. Should still be reviewed one commit at a time though.
    
    ### Commit 1: Support arbitrary `let`
    
    Before this change, all locals used in the body need to be declared at the top of the `mir!` invocation, which is rather annoying. We attempt to change that.
    
    Unfortunately, we still have the requirement that the output of the `mir!` macro must resolve, typecheck, etc. Because of that, we can't just accept this in the THIR -> MIR parser because something like
    ```rust
    {
        let x = 0;
        Goto(other)
    }
    other = {
        RET = x;
        Return()
    }
    ```
    will fail to resolve. Instead, the implementation does macro shenanigans to find the let declarations and extract them as part of the `mir!` macro. That *works*, but it is fairly complicated and degrades debuginfo by quite a bit. Specifically, the spans for any statements and declarations that are affected by this are completely wrong. My guess is that this is a net improvement though.
    
    One way to recover some of the debuginfo would be to not support type annotations in the `let` statements, which would allow us to parse like `let $stmt:stmt`. That seems quite surprising though.
    
    ### Commit 2: Parse consts
    
    Reuses most of the const parsing from regular Mir building for building custom mir
    
    ### Commit 3: Parse statics
    
    Statics are slightly weird because the Mir primitive associated with them is a reference/pointer to them, so this is factored out separately.
    
    ### Commit 4: Fix some spans
    
    A bunch of the spans were non-ideal, so we adjust them to be much more helpful.
    
    r? `@oli-obk`
    Dylan-DPC committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    77c39e5 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#105003 - flba-eb:only_windows, r=Mark-Simul…

    …acrum
    
    Run Windows-only tests only on Windows
    
    This removes the need to maintain an ignore-list of all other OSs.
    
    See rust-lang#102305 for a similar change.
    Dylan-DPC committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    2377177 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#105078 - TaKO8Ki:fix-105011, r=nnethercote

    Fix `expr_to_spanned_string` ICE
    
    Fixes rust-lang#105011
    Dylan-DPC committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    7a7b885 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#105087 - HKalbasi:master, r=eddyb

    Extract llvm datalayout parsing out of spec module
    
    fix rust-lang#103693 (comment)
    Dylan-DPC committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    8bdae2e View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#105088 - notriddle:notriddle/search-results…

    …-div-desc, r=GuillaumeGomez
    
    rustdoc: remove redundant CSS `div.desc { display: block }`
    
    DIV tags have block display by default. It is from when this rule used to target a SPAN tag, but became redundant in 4bd6748.
    Dylan-DPC committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    de9f772 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#105106 - jhpratt:issue-105101, r=TaKO8Ki

    Fix ICE from rust-lang#105101
    
    Fixes rust-lang#105101
    
    Rather than comparing idents, compare spans, which should be unique to each variant.
    Dylan-DPC committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    e318732 View commit details
    Browse the repository at this point in the history