Enable new rlib in non stable cases #105601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
I'll review this after the holidays. |
This comment was marked as resolved.
This comment was marked as resolved.
src/test/ui/native-library-link-flags/mix-bundle-and-whole-archive.stderr
Outdated
Show resolved
Hide resolved
petrochenkov
added
S-waiting-on-author
belovdv
force-pushed
the
change-rlib-with-not-stable
branch
from
4e73148
to
145ffdf
Compare
|
Changes: branch rebased, added run-make test, minor fixes. |
rustbot
added
S-waiting-on-review
petrochenkov
added
S-waiting-on-author
rustbot
added
the
A-translation
|
|
belovdv
force-pushed
the
change-rlib-with-not-stable
branch
from
c610299
to
95bb861
Compare
petrochenkov
reviewed
Feb 7, 2023
belovdv
force-pushed
the
change-rlib-with-not-stable
branch
from
95bb861
to
4098db6
Compare
petrochenkov
reviewed
Feb 7, 2023
|
r=me after addressing #105601 (comment) and squashing commits. |
belovdv
force-pushed
the
change-rlib-with-not-stable
branch
from
4098db6
to
f45b31a
Compare
|
@bors r+ |
|
📌 Commit f45b31a38332b6a7eaa20061c514351daf381a2f has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
|
⌛ Testing commit f45b31a38332b6a7eaa20061c514351daf381a2f with merge 04b5f1051585446a9b8ca6d7ff5c8fa3e9f960d5... |
|
@bors r+ |
bors
added
S-waiting-on-bors
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Feb 12, 2023
…e, r=petrochenkov Enable new rlib in non stable cases If bundled static library uses cfg (unstable) or whole-archive (wasn't supported) bundled libs are packed even without packed_bundled_libs. r? `@petrochenkov`
|
☀️ Test successful - checks-actions |
1 similar comment
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (51cb561): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. |
This was referenced Feb 15, 2023
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 16, 2023
…l, r=petrochenkov note issue for feature(packed_bundled_libs) Add to feature (introduced in rust-lang#105601) gate description number of issue created for it. r? `@petrochenkov`
This was referenced Apr 27, 2023
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2023
Fixes rust-lang#110912 Checking `flavor == RlibFlavor::Normal` was accidentally lost in 601fc8b rust-lang#105601 That caused combining +whole-archive and +bundle link modifiers on non-rlib crates to fail with a confusing error message saying that combination is unstable for rlibs. In particular, this caused the build to fail when +whole-archive was used on staticlib crates, even though +whole-archive effectively does nothing on non-bin crates because the final linker invocation is left to an external build system.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 28, 2023
…b_fix, r=petrochenkov only error combining +whole-archive and +bundle for rlibs Fixes rust-lang#110912 Checking `flavor == RlibFlavor::Normal` was accidentally lost in 601fc8b rust-lang#105601 That caused combining +whole-archive and +bundle link modifiers on non-rlib crates to fail with a confusing error message saying that combination is unstable for rlibs. In particular, this caused the build to fail when +whole-archive was used on staticlib crates, even though +whole-archive effectively does nothing on non-bin crates because the final linker invocation is left to an external build system. cc `@petrochenkov`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 28, 2023
…b_fix, r=petrochenkov only error combining +whole-archive and +bundle for rlibs Fixes rust-lang#110912 Checking `flavor == RlibFlavor::Normal` was accidentally lost in 601fc8b rust-lang#105601 That caused combining +whole-archive and +bundle link modifiers on non-rlib crates to fail with a confusing error message saying that combination is unstable for rlibs. In particular, this caused the build to fail when +whole-archive was used on staticlib crates, even though +whole-archive effectively does nothing on non-bin crates because the final linker invocation is left to an external build system. cc ``@petrochenkov``
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
Apr 30, 2023
…petrochenkov only error combining +whole-archive and +bundle for rlibs Fixes rust-lang/rust#110912 Checking `flavor == RlibFlavor::Normal` was accidentally lost in 601fc8b36b1962285e371cf3c54eeb3b1b9b3a74 rust-lang/rust#105601 That caused combining +whole-archive and +bundle link modifiers on non-rlib crates to fail with a confusing error message saying that combination is unstable for rlibs. In particular, this caused the build to fail when +whole-archive was used on staticlib crates, even though +whole-archive effectively does nothing on non-bin crates because the final linker invocation is left to an external build system. cc ``@petrochenkov``
pnkfelix
reviewed
May 4, 2023
| NativeLibKind::Static { bundle: None | Some(true), whole_archive: Some(true) } | ||
| if flavor == RlibFlavor::Normal => | ||
| { | ||
| // Don't allow mixing +bundle with +whole_archive since an rlib may contain |
There was a problem hiding this comment.
this comment was lost along with the code, and though the code was readded in #110917, the comment was not readded
Mark-Simulacrum
pushed a commit
to Mark-Simulacrum/rust
that referenced
this pull request
May 6, 2023
Fixes rust-lang#110912 Checking `flavor == RlibFlavor::Normal` was accidentally lost in 601fc8b rust-lang#105601 That caused combining +whole-archive and +bundle link modifiers on non-rlib crates to fail with a confusing error message saying that combination is unstable for rlibs. In particular, this caused the build to fail when +whole-archive was used on staticlib crates, even though +whole-archive effectively does nothing on non-bin crates because the final linker invocation is left to an external build system.
MabezDev
pushed a commit
to esp-rs/rust
that referenced
this pull request
May 30, 2023
Fixes rust-lang#110912 Checking `flavor == RlibFlavor::Normal` was accidentally lost in 601fc8b rust-lang#105601 That caused combining +whole-archive and +bundle link modifiers on non-rlib crates to fail with a confusing error message saying that combination is unstable for rlibs. In particular, this caused the build to fail when +whole-archive was used on staticlib crates, even though +whole-archive effectively does nothing on non-bin crates because the final linker invocation is left to an external build system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If bundled static library uses cfg (unstable) or whole-archive (wasn't supported) bundled libs are packed even without packed_bundled_libs.
r? @petrochenkov