Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctly update goals in the cache #107799

Merged
merged 2 commits into from
Feb 9, 2023

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Feb 8, 2023

we may want to actually write the response for our goal into the provisional or global cache instead of simply using the result from the last iteration '^^

r? @rust-lang/initiative-trait-system-refactor

@rustbot
Copy link
Collaborator

rustbot commented Feb 8, 2023

Team or group rust-lang/initiative-trait-system-refactor not found.

rust-lang team names can be found at https://github.com/rust-lang/team/tree/master/teams.
Reviewer group names can be found in triagebot.toml in this repo.

@rustbot
Copy link
Collaborator

rustbot commented Feb 8, 2023

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Feb 8, 2023
@rustbot
Copy link
Collaborator

rustbot commented Feb 8, 2023

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

@oli-obk
Copy link
Contributor

oli-obk commented Feb 8, 2023

r=me with tidy happy and commits squashed

@@ -0,0 +1,38 @@
// known-bug: unknown
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently still ICEs because other part of the solver aren't implemented yet 😅

@lcnr
Copy link
Contributor Author

lcnr commented Feb 8, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 8, 2023

📌 Commit 4c7c5e5 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 8, 2023
@compiler-errors
Copy link
Member

@bors r=oli-obk
(approver was wrong)

@bors
Copy link
Contributor

bors commented Feb 9, 2023

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Feb 9, 2023

📌 Commit 4c7c5e5 has been approved by oli-obk

It is now in the queue for this repository.

compiler-errors added a commit to compiler-errors/rust that referenced this pull request Feb 9, 2023
…oli-obk

correctly update goals in the cache

we may want to actually write the response for our goal into the provisional or global cache instead of simply using the result from the last iteration '^^

r? `@rust-lang/initiative-trait-system-refactor`
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Feb 9, 2023
…oli-obk

correctly update goals in the cache

we may want to actually write the response for our goal into the provisional or global cache instead of simply using the result from the last iteration '^^

r? ``@rust-lang/initiative-trait-system-refactor``
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 9, 2023
…mpiler-errors

Rollup of 9 pull requests

Successful merges:

 - rust-lang#107317 (Implement `AsFd` and `AsRawFd` for `Rc`)
 - rust-lang#107429 (Stabilize feature `cstr_from_bytes_until_nul`)
 - rust-lang#107713 (Extend `BYTE_SLICE_IN_PACKED_STRUCT_WITH_DERIVE`.)
 - rust-lang#107761 (Replace a command line flag with an env var to allow tools to initialize the tracing loggers at their own discretion)
 - rust-lang#107790 ( x.py fails all downloads that use a tempdir with snap curl rust-lang#107722)
 - rust-lang#107799 (correctly update goals in the cache)
 - rust-lang#107813 (Do not eagerly recover for bad `impl Trait` types in macros)
 - rust-lang#107817 (rustdoc: use svgo to shrink `wheel.svg`)
 - rust-lang#107819 (Set `rust-analyzer.check.invocationLocation` to `root`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 46c7c91 into rust-lang:master Feb 9, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 9, 2023
@lcnr lcnr deleted the update-provisional-result branch February 9, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants