Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report WF error for chalk *and* new solver #106525

Merged
merged 1 commit into from
Jan 7, 2023

Conversation

compiler-errors
Copy link
Member

addressing this nit #106385 (comment)

No test yet because new solver is currently unusable, lol

r? @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 6, 2023
@jackh726
Copy link
Member

jackh726 commented Jan 7, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 7, 2023

📌 Commit a9d093b has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 7, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 7, 2023
…mpiler-errors

Rollup of 4 pull requests

Successful merges:

 - rust-lang#106525 (Report WF error for chalk *and* new solver)
 - rust-lang#106533 (Use smaller spans for missing lifetime/generic args)
 - rust-lang#106543 (rustdoc: remove no-op CSS `.rustdoc.source .sidebar { width: 0 }`)
 - rust-lang#106554 (Fix a typo in the explanation of E0588)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 258257a into rust-lang:master Jan 7, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 7, 2023
@BoxyUwU BoxyUwU added the WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) label Jan 11, 2023
@compiler-errors compiler-errors deleted the new-solver-wf branch August 11, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants