rustdoc: remove no-op CSS .rustdoc.source .sidebar { width: 0 }
#106543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
GuillaumeGomez
approved these changes
Jan 6, 2023
|
Thanks! r=me once CI pass |
This comment has been minimized.
This comment has been minimized.
notriddle
force-pushed
the
notriddle/source-sidebar-width-zero
branch
from
d338b2c to
16a3c80
Compare
|
Wound up needing to fix a few test cases and work around the |
|
@bors r=GuillaumeGomez rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 7, 2023
…mpiler-errors Rollup of 4 pull requests Successful merges: - rust-lang#106525 (Report WF error for chalk *and* new solver) - rust-lang#106533 (Use smaller spans for missing lifetime/generic args) - rust-lang#106543 (rustdoc: remove no-op CSS `.rustdoc.source .sidebar { width: 0 }`) - rust-lang#106554 (Fix a typo in the explanation of E0588) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CSS was added in dc2c972, before 6a5f8b1 when the sidebars were merged.
Now that they are merged, the source sidebar is being pushed off-screen anyway, so giving it zero width doesn't do much.