Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #107324

Closed
wants to merge 120 commits into from
Closed

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Noratrieb and others added 30 commits December 13, 2022 18:08
It's not about "uninit" anymore but about "filling with 0x01 bytes" so
the name should at least try to reflect that.
Was accidentally removed in 808cba2
These are the last remaining platform intrinsics necessary for portable-simd.
v2 depends on Node.js 12 which will be removed from GHA in the near future
This reverts commit b5ac64b.

It entirely breaks PrintOnPanic as ICE seems to be considered a fatal error too.
…, r=RalfJung

Rename `assert_uninit_valid` intrinsic

It's not about "uninit" anymore but about "filling with 0x01 bytes" so the name should at least try to reflect that.

This is actually not fully correct though, as it does still panic for all uninit with `-Zstrict-init-checks`. I'm not sure what the best way is to deal with that not causing confusion. I guess we could just remove the flag? I don't think having it makes a lot of sense anymore with the direction that we have chose to go. It could be relevant again if rust-lang#100423 lands so removing it may be a bit over eager.

r? `@RalfJung`
bjorn3 and others added 17 commits January 24, 2023 18:56
It fixes a bug that caused compilation on 32bit x86 to fail
…, r=davidtwco

Preserve split DWARF files when building archives.

r? `@davidtwco`
Handle diagnostics customization on the fluent side (for one specific diagnostic)

r? `@davidtwco`
Migrate mir_build's borrow conflicts

This also changes the error message slightly, for two reasons:

- I'm not a fan of saying "value borrowed, by `x`, here"
- it simplifies the error implementation significantly.
…=cjgillot

`ty::tls` cleanups

Pull it out into a separate file, make the conditional compilation more obvious and give the internal functions better names.

Pulled out of rust-lang#106311

r? cjgillot
…orest,can-we-know-it-wasnt-revealed, r=oli-obk

Use a type-alias-impl-trait in `ObligationForest`
…bjorn3

Sync rustc_codegen_cranelift

For cg_clif itself there have been a couple of bug fixes since the last sync, a Cranelift update and implemented all remaining simd platform intrinsics used by `std::simd`. (`std::arch` still misses a lot though) Most of the diff is from reworking of the cg_clif build system though.

r? `@ghost`

`@rustbot` label +A-codegen +A-cranelift +T-compiler
Replace ZST operands and debuginfo by constants.

This is work that ConstProp will not have to do.
Split from rust-lang#107267
Custom mir: Add support for some remaining, easy to support constructs

Some documentation for previous changes and support for `Deinit`, checked binops, len, and array repetition

r? `@oli-obk` or `@tmiasko`
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 26, 2023
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=9

@bors
Copy link
Contributor

bors commented Jan 26, 2023

📌 Commit f183e30 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 26, 2023
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-llvm-13 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
Prepare all required actions
Getting action download info
Download action repository 'actions/checkout@v3' (SHA:ac593985615ec2ede58e132d2e21d2b1cbd6127c)
Download action repository 'rust-lang/simpleinfra@master' (SHA:8c19d39c6d9d7e831f6e393b2a871216393a5761)
Complete job name: PR (x86_64-gnu-llvm-13, false, ubuntu-20.04-xl)
git config --global core.autocrlf false
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  CI_JOB_NAME: x86_64-gnu-llvm-13
---
Some tests failed in compiletest suite=mir-opt mode=mir-opt host=x86_64-unknown-linux-gnu target=x86_64-unknown-linux-gnu
..ii.......i................................
failures:

---- [mir-opt] tests/mir-opt/intrinsic_asserts.rs stdout ----
8       let _3: ();                          // in scope 0 at $DIR/intrinsic_asserts.rs:+3:5: +3:61
10       bb0: {
10       bb0: {
-           StorageLive(_1);                 // scope 0 at $DIR/intrinsic_asserts.rs:+1:5: +1:47
+           nop;                             // scope 0 at $DIR/intrinsic_asserts.rs:+1:5: +1:47
12 -         _1 = assert_inhabited::<()>() -> bb1; // scope 0 at $DIR/intrinsic_asserts.rs:+1:5: +1:47
13 -                                          // mir::Constant
14 -                                          // + span: $DIR/intrinsic_asserts.rs:7:5: 7:45
17       }
18   
19       bb1: {
19       bb1: {
-           StorageDead(_1);                 // scope 0 at $DIR/intrinsic_asserts.rs:+1:47: +1:48
-           StorageLive(_2);                 // scope 0 at $DIR/intrinsic_asserts.rs:+2:5: +2:48
+           nop;                             // scope 0 at $DIR/intrinsic_asserts.rs:+1:47: +1:48
+           nop;                             // scope 0 at $DIR/intrinsic_asserts.rs:+2:5: +2:48
22 -         _2 = assert_zero_valid::<u8>() -> bb2; // scope 0 at $DIR/intrinsic_asserts.rs:+2:5: +2:48
23 -                                          // mir::Constant
24 -                                          // + span: $DIR/intrinsic_asserts.rs:8:5: 8:46
27       }
28   
29       bb2: {
29       bb2: {
-           StorageDead(_2);                 // scope 0 at $DIR/intrinsic_asserts.rs:+2:48: +2:49
-           StorageLive(_3);                 // scope 0 at $DIR/intrinsic_asserts.rs:+3:5: +3:61
+           nop;                             // scope 0 at $DIR/intrinsic_asserts.rs:+2:48: +2:49
+           nop;                             // scope 0 at $DIR/intrinsic_asserts.rs:+3:5: +3:61
32 -         _3 = assert_mem_uninitialized_valid::<u8>() -> bb3; // scope 0 at $DIR/intrinsic_asserts.rs:+3:5: +3:61
33 -                                          // mir::Constant
34 -                                          // + span: $DIR/intrinsic_asserts.rs:9:5: 9:59
37       }
38   
39       bb3: {
39       bb3: {
-           StorageDead(_3);                 // scope 0 at $DIR/intrinsic_asserts.rs:+3:61: +3:62
+           nop;                             // scope 0 at $DIR/intrinsic_asserts.rs:+3:61: +3:62
41           nop;                             // scope 0 at $DIR/intrinsic_asserts.rs:+0:20: +4:2
42           return;                          // scope 0 at $DIR/intrinsic_asserts.rs:+4:2: +4:2


thread '[mir-opt] tests/mir-opt/intrinsic_asserts.rs' panicked at 'Actual MIR output differs from expected MIR output /checkout/tests/mir-opt/intrinsic_asserts.removable.InstCombine.diff', src/tools/compiletest/src/runtest.rs:3483:21


failures:
    [mir-opt] tests/mir-opt/intrinsic_asserts.rs

@matthiaskrgr matthiaskrgr deleted the rollup-r3nzkqk branch March 16, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.