Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 7 pull requests #108127

Merged
merged 24 commits into from
Feb 16, 2023
Merged

Rollup of 7 pull requests #108127

merged 24 commits into from
Feb 16, 2023

Commits on Feb 14, 2023

  1. Prevent some attributes from being merged with others on reexports

    @GuillaumeGomez
    GuillaumeGomez committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    5f93edd View commit details
    Browse the repository at this point in the history

  2. More accurate spans for arg removal suggestion

    @estebank
    estebank committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    f02d8ec View commit details
    Browse the repository at this point in the history

  3. Fix fmt

    @estebank
    estebank committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    fb61f5d View commit details
    Browse the repository at this point in the history

  4. Avoid trailing commas

    @estebank
    estebank committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    287cd59 View commit details
    Browse the repository at this point in the history

  5. rebase and review comments

    @estebank
    estebank committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    5d63e10 View commit details
    Browse the repository at this point in the history

  6. Make removal suggestion not verbose

    @estebank
    estebank committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    bd176ee View commit details
    Browse the repository at this point in the history

  7. Show the effects of weird code commented out

    @estebank
    estebank committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    755252b View commit details
    Browse the repository at this point in the history

  8. Re-add replacement logic and add comment explaining it

    @estebank
    estebank committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    dff10d0 View commit details
    Browse the repository at this point in the history

  9. Correctly handle reexport traversal by fixing multiple bugs, especial… 

    …ly for items with a path of 1 element
    @GuillaumeGomez
    GuillaumeGomez committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    02a845a View commit details
    Browse the repository at this point in the history

  10. Add test for reexports attr merge

    @GuillaumeGomez
    GuillaumeGomez committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    1ec1d94 View commit details
    Browse the repository at this point in the history

  11. Correctly handle reexports of #[doc(hidden)] is reexport does not u… 

    …se `#[doc(inline)]`
    @GuillaumeGomez
    GuillaumeGomez committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    374f798 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2023

  1. use chars instead of strings where applicable

    @matthiaskrgr
    matthiaskrgr committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    0400c68 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2023

  1. note issue for feature(packed_bundled_libs)

    @belovdv
    belovdv committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    b488508 View commit details
    Browse the repository at this point in the history

  2. Do not ICE on unmet trait alias bounds

    @eggyal
    eggyal committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    540bd98 View commit details
    Browse the repository at this point in the history

  3. if $c:expr { Some($r:expr) } else { None } =>> $c.then(|| $r)

    @WaffleLapkin
    WaffleLapkin committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    8751fa1 View commit details
    Browse the repository at this point in the history

  4. Replace some thens with some then_somes

    @WaffleLapkin
    WaffleLapkin committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    5bf6a46 View commit details
    Browse the repository at this point in the history

  5. Add new people to the compiletest review rotation

    @albertlarsan68
    albertlarsan68 authored Feb 16, 2023
    Configuration menu
    Copy the full SHA
    3230577 View commit details
    Browse the repository at this point in the history

  6. Rollup merge of rust-lang#106347 - estebank:removal-suggestion, r=TaK… 

    …O8Ki

More accurate spans for arg removal suggestion

Partially address rust-lang#106304.
    @matthiaskrgr
    matthiaskrgr authored Feb 16, 2023
    Configuration menu
    Copy the full SHA
    f65c6e4 View commit details
    Browse the repository at this point in the history

  7. Rollup merge of rust-lang#108057 - GuillaumeGomez:fix-reexport-attr-m… 

    …erge, r=notriddle

Prevent some attributes from being merged with others on reexports

Final fix for rust-lang#59368.

As discussed on zulip [here](https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/Filtering.20sub.20attributes.20in.20ast.3A.3AAttribute), we need to clone the `Attribute` to be able to filter some parts of it. Then we need to go through the attributes to able to only keep what we want (everything except a few attributes in short).

As for the second commit, when I wrote the test, I realized that the code to traverse all reexports one by one to collect all their attributes was not completely working so I fixed the few issues remaining.

r? `@notriddle`
    @matthiaskrgr
    matthiaskrgr authored Feb 16, 2023
    Configuration menu
    Copy the full SHA
    0412898 View commit details
    Browse the repository at this point in the history

  8. Rollup merge of rust-lang#108090 - WaffleLapkin:if_not_now_then_when…… 

    …, r=oli-obk

`if $c:expr { Some($r:expr) } else { None }` =>> `$c.then(|| $r)`

Resurrection of rust-lang#108079
    @matthiaskrgr
    matthiaskrgr authored Feb 16, 2023
    Configuration menu
    Copy the full SHA
    64a4f70 View commit details
    Browse the repository at this point in the history

  9. Rollup merge of rust-lang#108092 - BelovDV:fix-feature-description-pb… 

    …l, r=petrochenkov

note issue for feature(packed_bundled_libs)

Add to feature (introduced in rust-lang#105601) gate description number of issue created for it.

r? `@petrochenkov`
    @matthiaskrgr
    matthiaskrgr authored Feb 16, 2023
    Configuration menu
    Copy the full SHA
    2dc21c0 View commit details
    Browse the repository at this point in the history

  10. Rollup merge of rust-lang#108099 - matthiaskrgr:str_to_char, r=Guilla… 

    …umeGomez

use chars instead of strings where applicable
    @matthiaskrgr
    matthiaskrgr authored Feb 16, 2023
    Configuration menu
    Copy the full SHA
    09a2267 View commit details
    Browse the repository at this point in the history

  11. Rollup merge of rust-lang#108115 - eggyal:unmet_trait_alias_bound, r=… 

    …compiler-errors

Do not ICE on unmet trait alias bounds

Rework of rust-lang#108093 following feedback on that PR.

Fixes rust-lang#108072

r? `@compiler-errors`
    @matthiaskrgr
    matthiaskrgr authored Feb 16, 2023
    Configuration menu
    Copy the full SHA
    d77b022 View commit details
    Browse the repository at this point in the history

  12. Rollup merge of rust-lang#108125 - albertlarsan68:moar-compiletest-re… 

    …viewers, r=wesleywiser

Add new people to the compiletest review rotation

`@oli-obk` and `@wesleywiser` volunteered to be part of the review rotation of compiletest in https://rust-lang.zulipchat.com/#narrow/stream/238009-t-compiler.2Fmeetings/topic/.5Bweekly.5D.202023-02-16/near/328274017
    @matthiaskrgr
    matthiaskrgr authored Feb 16, 2023
    Configuration menu
    Copy the full SHA
    eb9f9c7 View commit details
    Browse the repository at this point in the history