Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazily compute crate name for consider_optimizing #108405

Merged
merged 1 commit into from
Mar 4, 2023
Merged

Lazily compute crate name for consider_optimizing #108405

merged 1 commit into from
Mar 4, 2023

Conversation

Noratrieb
Copy link
Member

The extra query is unnecessary in the common case of not having fuel.

@Noratrieb
Lazily compute crate name for consider_optimizing
7ee01b4 
The extra query is unnecessary in the common case of not having fuel.
@rustbot
Copy link
Collaborator

rustbot commented Feb 23, 2023

r? @nagisa

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 23, 2023
@Noratrieb
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 23, 2023
@bors
Copy link
Contributor

bors commented Feb 23, 2023

⌛ Trying commit 7ee01b4 with merge aaf59756a2b81a61d9092992635345cf399122f2...

@bors
Copy link
Contributor

bors commented Feb 23, 2023

☀️ Try build successful - checks-actions
Build commit: aaf59756a2b81a61d9092992635345cf399122f2 (aaf59756a2b81a61d9092992635345cf399122f2)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (aaf59756a2b81a61d9092992635345cf399122f2): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.7% [2.7%, 2.7%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 23, 2023
WaffleLapkin
WaffleLapkin approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@WaffleLapkin WaffleLapkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perf change looks like noise (coercions? again?), ig the crate_name(LOCAL_CRATE) query is always cached?

I think this makes sense as a little cleanup.

@WaffleLapkin
Copy link
Member

r? @WaffleLapkin
@bors r+

@bors
Copy link
Contributor

bors commented Feb 24, 2023

📌 Commit 7ee01b4 has been approved by WaffleLapkin

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Feb 24, 2023

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 24, 2023
@Noratrieb
Copy link
Member Author

@bors rollup=maybe was perf neutral and the queue is filled up

@Dylan-DPC Dylan-DPC mentioned this pull request Feb 27, 2023
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Feb 27, 2023
@Dylan-DPC
Rollup merge of rust-lang#108405 - Nilstrieb:lazy-crate-name-optimiza…
8d77c03 
…tion-fuel, r=WaffleLapkin

Lazily compute crate name for consider_optimizing

The extra query is unnecessary in the common case of not having fuel.
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Feb 28, 2023
@Dylan-DPC
Rollup merge of rust-lang#108405 - Nilstrieb:lazy-crate-name-optimiza…
96dd30a 
…tion-fuel, r=WaffleLapkin

Lazily compute crate name for consider_optimizing

The extra query is unnecessary in the common case of not having fuel.
@Dylan-DPC Dylan-DPC mentioned this pull request Feb 28, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 1, 2023
@matthiaskrgr
Rollup merge of rust-lang#108405 - Nilstrieb:lazy-crate-name-optimiza…
4ebf78a 
…tion-fuel, r=WaffleLapkin

Lazily compute crate name for consider_optimizing

The extra query is unnecessary in the common case of not having fuel.
This was referenced Mar 1, 2023
Closed
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 1, 2023
@matthiaskrgr
Rollup merge of rust-lang#108405 - Nilstrieb:lazy-crate-name-optimiza…
f33dbe9 
…tion-fuel, r=WaffleLapkin

Lazily compute crate name for consider_optimizing

The extra query is unnecessary in the common case of not having fuel.
@Dylan-DPC Dylan-DPC mentioned this pull request Mar 4, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 4, 2023
@bors
Auto merge of rust-lang#108732 - Dylan-DPC:rollup-dy1l8sx, r=Dylan-DPC
276b75a 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#108298 (Fix ICE: check if snippet is `)`)
 - rust-lang#108405 (Lazily compute crate name for consider_optimizing)
 - rust-lang#108656 (Rustdoc search: Emit an error for unclosed generic)
 - rust-lang#108660 (Remove ne implementations from strings)
 - rust-lang#108669 (Allow checking whether a type allows being uninitialized)
 - rust-lang#108727 (rustc_expand: make proc-macro derive error translatable)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 832dab3 into rust-lang:master Mar 4, 2023
@rustbot rustbot added this to the 1.69.0 milestone Mar 4, 2023
@Noratrieb Noratrieb deleted the lazy-crate-name-optimization-fuel branch March 4, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WaffleLapkin WaffleLapkin WaffleLapkin approved these changes

Assignees

@WaffleLapkin WaffleLapkin

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Noratrieb @rustbot @rust-timer @bors @WaffleLapkin @nagisa