Rollup of 8 pull requests #108709
Merged
Rollup of 8 pull requests #108709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been replaced by stage-build.py.
And a couple of other places.
…ecutable-symbols, r=WaffleLapkin add -Zexport-executable-symbols to unstable book This flag has been extremely useful to me, but it's hard to discover. The text contains a bunch of terms that hopefully a search engine will pick up on when someone searches for this functionality.
…ere, r=oli-obk Label opaque type for 'captures lifetime' error message Providing more information may help make this somewhat opaque (lol) error message a bit clearer.
…ingy_pointer, r=m-ou-se
Add `Atomic*::from_ptr`
This PR adds functions in the following form to all atomic types:
```rust
impl AtomicT {
pub const unsafe fn from_ptr<'a>(ptr: *mut T) -> &'a AtomicT;
}
```
r? `@m-ou-se` (we've talked about it before)
I'm not sure about docs & safety requirements, I'd appreciate some feedback on them.
Add link to component dashboard It's a pain to find otherwise.
Remove dead pgo.sh file This has been replaced by stage-build.py.
…trieb Use `Option::as_slice` where applicable After rust-lang#105871 introduced `Option::as_slice`, this PR uses it within the compiler. I found it interesting that all cases where `as_slice` could be used were done with different code before; so it seems the new API also has the benefit of being "the obvious solution" where before there was a mix of options, none clearly better than the rest.
…on-comments, r=lqd Improve comments in `needs_process_obligation`. And a couple of other places. r? `@lqd`
…y, r=jyn514
Match unmatched backticks in library/
Found with GNU grep:
```
grep -rEn '^(([^`]*`){2})*[^`]*`[^`]*$' library/ | rg -v '\s*[//]?.{1,2}```'
```
split out from rust-lang#108685 as per advice.
rustbot
added
A-testsuite
|
@bors r+ rollup=never p=8 |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 7a228ce with merge e62e3907dc50c0d2847ff145fde58679ce8a626a... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
bors
added
S-waiting-on-bors
|
@bors retry could not create temporary file whilst writing archive: no more archived files spurious it seems |
|
oops lol |
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: previous master: 44cfafe2fa In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Mar 4, 2023
|
Finished benchmarking commit (70adb4e): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
The improvements here are in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Atomic*::from_ptr#108540 (AddAtomic*::from_ptr)Option::as_slicewhere applicable #108678 (UseOption::as_slicewhere applicable)needs_process_obligation. #108681 (Improve comments inneeds_process_obligation.)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup