Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label opaque type for 'captures lifetime' error message #108292

Merged
merged 2 commits into from
Mar 4, 2023

Conversation

compiler-errors
Copy link
Member

Providing more information may help make this somewhat opaque (lol) error message a bit clearer.

@rustbot
Copy link
Collaborator

rustbot commented Feb 21, 2023

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 21, 2023
@rustbot
Copy link
Collaborator

rustbot commented Feb 21, 2023

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @TaKO8Ki

@@ -17,8 +17,9 @@ error[E0700]: hidden type for `impl Trait<'a>` captures lifetime that does not a
--> $DIR/ret-impl-trait-one.rs:16:80
|
LL | async fn async_ret_impl_trait1<'a, 'b>(a: &'a u8, b: &'b u8) -> impl Trait<'a> {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this sucks, but it already sucked so... 🤷

@compiler-errors
Copy link
Member Author

r? compiler

since jack said that he was going to be unavailable for a week

@rustbot rustbot assigned lcnr and unassigned jackh726 Feb 22, 2023
@compiler-errors
Copy link
Member Author

compiler-errors commented Feb 22, 2023

lcnr has too many of my prs already 🤣

r? @oli-obk

@rustbot rustbot assigned oli-obk and unassigned lcnr Feb 22, 2023
@bors
Copy link
Contributor

bors commented Feb 22, 2023

☔ The latest upstream changes (presumably #103042) made this pull request unmergeable. Please resolve the merge conflicts.

@oli-obk
Copy link
Contributor

oli-obk commented Mar 3, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 3, 2023

📌 Commit bdacc8b has been approved by oli-obk

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 3, 2023

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 3, 2023
…ere, r=oli-obk

Label opaque type for 'captures lifetime' error message

Providing more information may help make this somewhat opaque (lol) error message a bit clearer.
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 3, 2023
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#104549 (add -Zexport-executable-symbols to unstable book)
 - rust-lang#108292 (Label opaque type for 'captures lifetime' error message)
 - rust-lang#108540 (Add `Atomic*::from_ptr`)
 - rust-lang#108634 (Add link to component dashboard)
 - rust-lang#108647 (Remove dead pgo.sh file)
 - rust-lang#108678 (Use `Option::as_slice` where applicable)
 - rust-lang#108681 (Improve comments in `needs_process_obligation`.)
 - rust-lang#108688 (Match unmatched backticks in library/)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 188ed14 into rust-lang:master Mar 4, 2023
@rustbot rustbot added this to the 1.69.0 milestone Mar 4, 2023
@compiler-errors compiler-errors deleted the opaque-captures-where branch August 11, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants