Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for missing codegen backeng config #109642

Conversation

lenko-d
Copy link
Contributor

@lenko-d lenko-d commented Mar 26, 2023

Fixes #109610

@rustbot
Copy link
Collaborator

rustbot commented Mar 26, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 26, 2023
@rust-log-analyzer

This comment has been minimized.

@lenko-d
Copy link
Contributor Author

lenko-d commented Mar 27, 2023

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 27, 2023
@lenko-d lenko-d force-pushed the rust_codegen-backends_interacts_confusingly_with_paths branch from 1a23f3e to 88b3ae9 Compare March 27, 2023 04:46
@lenko-d
Copy link
Contributor Author

lenko-d commented Mar 27, 2023

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 27, 2023
@Mark-Simulacrum
Copy link
Member

I think this might be able to be cleaned up a little (not sure all the conditions are necessary), but it seems like a good change.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 2, 2023

📌 Commit 88b3ae9 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 2, 2023
…racts_confusingly_with_paths, r=Mark-Simulacrum

check for missing codegen backeng config

Fixes [rust-lang#109610](rust-lang#109610)
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 3, 2023
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#109526 (LIBPATH is used as dylib's path environment variable on AIX)
 - rust-lang#109642 (check for missing codegen backeng config)
 - rust-lang#109722 (Implement read_buf for RustHermit)
 - rust-lang#109856 (fix(middle): emit error rather than delay bug when reaching limit)
 - rust-lang#109868 (Improve PR job names in Github Actions preview)
 - rust-lang#109871 (Include invocation start times)
 - rust-lang#109873 (Move some UI tests into subdirectories)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit cc6a279 into rust-lang:master Apr 3, 2023
@rustbot rustbot added this to the 1.70.0 milestone Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rust.codegen-backends interacts confusingly with paths
5 participants