Only emit alignment checks if we have a panic_impl #110283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
|
It's a bit of a hack, but I guess it works for now. You can't hit this on stable as you need r=me with rustfmt applied |
|
We should probably add a no-core test to our test suite that triggers this. Something like #![feature(lang_items)]
#![feature(no_core)]
#![no_core]
#[lang = "sized"]
trait Foo {}
pub unsafe fn foo(x: *const i32) -> &'static i32 { unsafe { &*x } } |
saethlin
force-pushed
the
check-panics-before-alignment
branch
from
8af5138
to
4061eb5
Compare
|
@bors r=bjorn3 |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 13, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#109036 (Fix diff option conflict in UI test) - rust-lang#110193 (Check for body owner fallibly in error reporting) - rust-lang#110233 (Make rust-intrinsic ABI unwindable) - rust-lang#110259 (Added diagnostic for pin! macro in addition to Box::pin if Unpin isn't implemented) - rust-lang#110265 (Automatically update the LLVM submodule for musl target (and other places)) - rust-lang#110277 (dead-code-lint: de-dup multiple unused assoc functions) - rust-lang#110283 (Only emit alignment checks if we have a panic_impl) - rust-lang#110291 (Implement `Copy` for `LocationDetail`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #109996
r? @bjorn3 because you commented that this situation could impact you as well