Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests for libtest --format json #110644

Merged
merged 4 commits into from
Apr 29, 2023

Conversation

pietroalbini
Copy link
Member

This PR makes the test work on beta and stable, and adds a test ensuring the option is not available on beta and stable. Backported these commits from #110414.

@pietroalbini pietroalbini marked this pull request as ready for review April 21, 2023 13:43
@rustbot
Copy link
Collaborator

rustbot commented Apr 21, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 21, 2023
@rust-log-analyzer

This comment has been minimized.

@Mark-Simulacrum
Copy link
Member

r=me, but might need some sorting perhaps? Looks like maybe we have some non-determinism there.

@cuviper
Copy link
Member

cuviper commented Apr 28, 2023

@bors r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Apr 28, 2023

📌 Commit dc94522 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 28, 2023

🌲 The tree is currently closed for pull requests below priority 50. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 28, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 29, 2023
…sts, r=Mark-Simulacrum

Update tests for libtest `--format json`

This PR makes the test work on beta and stable, and adds a test ensuring the option is not available on beta and stable. Backported these commits from rust-lang#110414.
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Apr 29, 2023
…sts, r=Mark-Simulacrum

Update tests for libtest `--format json`

This PR makes the test work on beta and stable, and adds a test ensuring the option is not available on beta and stable. Backported these commits from rust-lang#110414.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 29, 2023
…sts, r=Mark-Simulacrum

Update tests for libtest `--format json`

This PR makes the test work on beta and stable, and adds a test ensuring the option is not available on beta and stable. Backported these commits from rust-lang#110414.
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 29, 2023
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#105848 (rustdoc: Add a new lint for broken inline code)
 - rust-lang#110644 (Update tests for libtest `--format json`)
 - rust-lang#110950 (Deny the `unsafe_op_in_unsafe_fn` lint in `rustc_arena`.)
 - rust-lang#110951 (Add support for LibreSSL 3.7.x)
 - rust-lang#110964 (rustdoc: fix weird margins between Deref impl items)
 - rust-lang#110979 (windows: kill rust-analyzer-proc-macro-srv before deleting stage0 directory)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 957a6ad into rust-lang:master Apr 29, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 29, 2023
ehuss added a commit to ehuss/rustc-guide that referenced this pull request Apr 29, 2023
tshepang pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request May 2, 2023
@pietroalbini pietroalbini deleted the pa-json-formatting-tests branch May 2, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants