Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deny the unsafe_op_in_unsafe_fn lint in rustc_arena. #110950

Merged
merged 1 commit into from
Apr 29, 2023
Merged

Deny the unsafe_op_in_unsafe_fn lint in rustc_arena. #110950

merged 1 commit into from
Apr 29, 2023

Conversation

JohnBobbo96
Copy link
Contributor

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 28, 2023
@JohnBobbo96 JohnBobbo96 mentioned this pull request Apr 28, 2023
Merged
@Noratrieb
Copy link
Member

Can you add safety comments?

@JohnBobbo96
Copy link
Contributor Author

I added safety comments

@bors
Copy link
Contributor

bors commented Apr 29, 2023

☔ The latest upstream changes (presumably #110967) made this pull request unmergeable. Please resolve the merge conflicts.

@Noratrieb
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 29, 2023

📌 Commit 47fb8e6 has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 29, 2023
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Apr 29, 2023
@GuillaumeGomez
Rollup merge of rust-lang#110950 - JohnBobbo96:rustc_arena_unsafe_fn,…
4a702c0 
… r=Nilstrieb

Deny the `unsafe_op_in_unsafe_fn` lint in `rustc_arena`.

r? `@Nilstrieb`
@GuillaumeGomez GuillaumeGomez mentioned this pull request Apr 29, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 29, 2023
@matthiaskrgr
Rollup merge of rust-lang#110950 - JohnBobbo96:rustc_arena_unsafe_fn,…
c1d876f 
… r=Nilstrieb

Deny the `unsafe_op_in_unsafe_fn` lint in `rustc_arena`.

r? ``@Nilstrieb``
This was referenced Apr 29, 2023
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 29, 2023
@bors
Auto merge of rust-lang#110994 - matthiaskrgr:rollup-wv4u5yi, r=matth…
eb62877 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#105848 (rustdoc: Add a new lint for broken inline code)
 - rust-lang#110644 (Update tests for libtest `--format json`)
 - rust-lang#110950 (Deny the `unsafe_op_in_unsafe_fn` lint in `rustc_arena`.)
 - rust-lang#110951 (Add support for LibreSSL 3.7.x)
 - rust-lang#110964 (rustdoc: fix weird margins between Deref impl items)
 - rust-lang#110979 (windows: kill rust-analyzer-proc-macro-srv before deleting stage0 directory)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0756c1c into rust-lang:master Apr 29, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 29, 2023
@JohnBobbo96 JohnBobbo96 deleted the rustc_arena_unsafe_fn branch April 29, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noratrieb Noratrieb Noratrieb approved these changes

Assignees

@Noratrieb Noratrieb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
4 participants
@JohnBobbo96 @Noratrieb @bors @rustbot