Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap: update paths cargo-credential crate #110744

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

weihanglo
Copy link
Member

@weihanglo weihanglo commented Apr 23, 2023

This should be done in #110653 but forgot.

Fixes #110742

How to verify this patch

Run ./x.py build cargo. Previously it would fail with

error: manifest path `/projects/rust/src/tools/cargo/crates/credential/cargo-credential-1password/Cargo.toml` does not exist

@rustbot
Copy link
Collaborator

rustbot commented Apr 23, 2023

r? @albertlarsan68

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Apr 23, 2023
@weihanglo
Copy link
Member Author

r? ehuss

Sorry and thanks!

@rustbot rustbot assigned ehuss and unassigned albertlarsan68 Apr 23, 2023
@ehuss
Copy link
Contributor

ehuss commented Apr 24, 2023

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 24, 2023

📌 Commit f5e535c has been approved by ehuss

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 24, 2023
…, r=ehuss

bootstrap: update paths cargo-credential crate

This should be done in rust-lang#110653 but forgot.

Fixes rust-lang#110742

## How to verify this patch

Run `./x.py build cargo`. Previously it would fail with

```console
error: manifest path `/projects/rust/src/tools/cargo/crates/credential/cargo-credential-1password/Cargo.toml` does not exist
```
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 24, 2023
…, r=ehuss

bootstrap: update paths cargo-credential crate

This should be done in rust-lang#110653 but forgot.

Fixes rust-lang#110742

## How to verify this patch

Run `./x.py build cargo`. Previously it would fail with

```console
error: manifest path `/projects/rust/src/tools/cargo/crates/credential/cargo-credential-1password/Cargo.toml` does not exist
```
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 24, 2023
…, r=ehuss

bootstrap: update paths cargo-credential crate

This should be done in rust-lang#110653 but forgot.

Fixes rust-lang#110742

## How to verify this patch

Run `./x.py build cargo`. Previously it would fail with

```console
error: manifest path `/projects/rust/src/tools/cargo/crates/credential/cargo-credential-1password/Cargo.toml` does not exist
```
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 24, 2023
Rollup of 10 pull requests

Successful merges:

 - rust-lang#110480 (Add `known-bug` tests for 11 unsound issues)
 - rust-lang#110539 (Move around `{Idx, IndexVec, IndexSlice}` adjacent code)
 - rust-lang#110590 (Add some tests around (lack of) object safety of associated types and consts)
 - rust-lang#110602 (Ignore src/bootstrap formatting commit in .git-blame-ignore-revs)
 - rust-lang#110667 (pointer-auth-link-with-c: Fix cross compilation.)
 - rust-lang#110681 (drop few unused crates, gate libc under unix for rustc_codegen_ssa)
 - rust-lang#110685 (Some cleanups to DataflowConstProp)
 - rust-lang#110744 (bootstrap: update paths cargo-credential crate)
 - rust-lang#110750 (Add size asserts for MIR `SourceScopeData` & `VarDebugInfo`)
 - rust-lang#110760 (rustdoc: Add regression test for rust-lang#60522)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b708aad into rust-lang:master Apr 24, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 24, 2023
@weihanglo weihanglo deleted the cargo-credential-install branch April 24, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
5 participants