Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #110753

Closed
wants to merge 28 commits into from

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

KisaragiEffective and others added 28 commits April 13, 2023 22:24
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
Add LazyCell::into_inner

This enables uses cases that need to extract the evaluated value and do something owned with it.
…Amanieu

stdarch: update submodule

We need [this commit](rust-lang/stdarch@cf3deea) introduced by [stdarch#1411](rust-lang/stdarch#1411) in order to merge rust-lang#110189.
…unsound-issues, r=jackh726

Add `known-bug` tests for 11 unsound issues

r? `@jackh726`

Should tests for other issues be in separate PRs?  Thanks.

Edit: Partially addresses rust-lang#105107.  This PR adds `known-bug` tests for 11 unsound issues:
- rust-lang#25860
- rust-lang#49206
- rust-lang#57893
- rust-lang#84366
- rust-lang#84533
- rust-lang#84591
- rust-lang#85099
- rust-lang#98117
- rust-lang#100041
- rust-lang#100051
- rust-lang#104005
…=jackh726

Add some tests around (lack of) object safety of associated types and consts

See https://rust-lang.zulipchat.com/#narrow/stream/144729-t-types/topic/.60where.20Self.3ASized.60.20on.20assoc.20types/near/351260928 for some discussion around why this isn't allowed.

We didn't have any tests for these, so I decided to add them now, even if we don't end up doing anything about it.
Some cleanups to DataflowConstProp

Mostly moving code around and short-circuiting useless cases.
format panic message only once

For `panic!` and friends, the `std` panic runtime will always set the `.payload()` of `PanicInfo` to the formatted string. The linked issues show that formatting the message twice can cause problems, so we simply print the already formatted message instead of formatting it again. We can't remove the preformatted payload, because it can be observed by custom panic hooks.

fixes rust-lang#110717
fixes rust-itertools/itertools#694

cc ``@Amanieu`` who broke this in rust-lang#109507
…, r=ehuss

bootstrap: update paths cargo-credential crate

This should be done in rust-lang#110653 but forgot.

Fixes rust-lang#110742

## How to verify this patch

Run `./x.py build cargo`. Previously it would fail with

```console
error: manifest path `/projects/rust/src/tools/cargo/crates/credential/cargo-credential-1password/Cargo.toml` does not exist
```
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Apr 24, 2023
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Apr 24, 2023
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=7

@bors
Copy link
Contributor

bors commented Apr 24, 2023

📌 Commit 723777d has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2023
@bors
Copy link
Contributor

bors commented Apr 24, 2023

⌛ Testing commit 723777d with merge 3eddc165c131249d9a763ae3002ba0d2f3b75458...

@rust-log-analyzer
Copy link
Collaborator

The job arm-android failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[RUSTC-TIMING] rustc_std_workspace_alloc test:false 0.030
   Compiling object v0.30.1
[RUSTC-TIMING] panic_abort test:false 0.098
[RUSTC-TIMING] panic_unwind test:false 0.109
error[E0425]: cannot find function `getauxval` in crate `libc`
   --> library/stdarch/crates/std_detect/src/detect/os/linux/auxvec.rs:148:40
    |
148 |             let hwcap = unsafe { libc::getauxval(AT_HWCAP as libc::c_ulong) as usize };

error[E0425]: cannot find function `getauxval` in crate `libc`
error[E0425]: cannot find function `getauxval` in crate `libc`
   --> library/stdarch/crates/std_detect/src/detect/os/linux/auxvec.rs:149:41
    |
149 |             let hwcap2 = unsafe { libc::getauxval(AT_HWCAP2 as libc::c_ulong) as usize };

For more information about this error, try `rustc --explain E0425`.
[RUSTC-TIMING] std_detect test:false 0.186
error: could not compile `std_detect` due to 2 previous errors

@bors
Copy link
Contributor

bors commented Apr 24, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 24, 2023
@matthiaskrgr matthiaskrgr deleted the rollup-iocs9s2 branch March 16, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants