Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode types in SMIR #110747

Merged
merged 2 commits into from
May 10, 2023
Merged

Encode types in SMIR #110747

merged 2 commits into from
May 10, 2023

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Apr 24, 2023

The first commit makes sure we can actually store a Ty<'tcx> (with the lifetime) in the thread local and get it back out. The second commit then introduces types.

r? @spastorino

@rustbot
Copy link
Collaborator

rustbot commented Apr 24, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @spastorino (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 24, 2023
@rustbot
Copy link
Collaborator

rustbot commented Apr 24, 2023

This PR changes Stable MIR

cc @oli-obk, @celinval

@spastorino
Copy link
Member

@oli-obk this looks good to me. Left a small comment but consider an r+ from me :).

spastorino
spastorino reviewed Apr 25, 2023
View reviewed changes
compiler/rustc_smir/src/stable_mir/mod.rs Outdated
ret
}

struct Dummy;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why do we need this, can you explain?.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed that for an intermediate stage where I wanted to get a vtable for a trait object, but I have since removed the need for it, but forgot to remove this type. I removed it from both commits.

@oli-obk
Copy link
Contributor Author

oli-obk commented May 8, 2023

@bors r=spastorino

@bors
Copy link
Contributor

bors commented May 8, 2023

📌 Commit 5c6e234 has been approved by spastorino

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 8, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request May 10, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 10, 2023
@bors
Auto merge of rust-lang#111414 - matthiaskrgr:rollup-q0qoc47, r=matth…
25444e5 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#110673 (Make alias bounds sound in the new solver (take 2))
 - rust-lang#110747 (Encode types in SMIR)
 - rust-lang#111095 (Correctly handle associated items of a trait inside a `#[doc(hidden)]` item)
 - rust-lang#111381 (Keep encoding attributes for closures)
 - rust-lang#111408 (Fix incorrect implication of transmuting slices)
 - rust-lang#111410 (Switch to `EarlyBinder` for `thir_abstract_const` query)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f192227 into rust-lang:master May 10, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spastorino spastorino spastorino left review comments

Assignees

@spastorino spastorino

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
4 participants
@oli-obk @rustbot @spastorino @bors