Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect implication of transmuting slices #111408

Merged
merged 1 commit into from
May 10, 2023
Merged

Fix incorrect implication of transmuting slices #111408

merged 1 commit into from
May 10, 2023

Conversation

TomMD
Copy link
Contributor

@TomMD TomMD commented May 9, 2023

transmute<&[u8]> would be useful and as a beginner it is confusing to see documents casually confuse the types of &[u8] and [u8; SZ]

@TomMD
Fix incorrect implication of transmuting slices
55d86b9 
transmute<&[u8]> would be useful and as a beginner it is confusing to see documents casually confuse the types of &[u8] and [u8; SZ]
@rustbot
Copy link
Collaborator

rustbot commented May 9, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @m-ou-se (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 9, 2023
@rustbot
Copy link
Collaborator

rustbot commented May 9, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@workingjubilee
Copy link
Member

True.
@bors r+ rollup=always

@bors
Copy link
Contributor

bors commented May 9, 2023

📌 Commit 55d86b9 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request May 10, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 10, 2023
@bors
Auto merge of rust-lang#111414 - matthiaskrgr:rollup-q0qoc47, r=matth…
25444e5 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#110673 (Make alias bounds sound in the new solver (take 2))
 - rust-lang#110747 (Encode types in SMIR)
 - rust-lang#111095 (Correctly handle associated items of a trait inside a `#[doc(hidden)]` item)
 - rust-lang#111381 (Keep encoding attributes for closures)
 - rust-lang#111408 (Fix incorrect implication of transmuting slices)
 - rust-lang#111410 (Switch to `EarlyBinder` for `thir_abstract_const` query)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f60a174 into rust-lang:master May 10, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 10, 2023
@TomMD TomMD deleted the patch-1 branch May 11, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@m-ou-se m-ou-se

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
5 participants
@TomMD @rustbot @workingjubilee @bors @m-ou-se