Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only error combining +whole-archive and +bundle for rlibs #110917

Merged
merged 1 commit into from
Apr 29, 2023

Commits on Apr 27, 2023

  1. only error with +whole-archive,+bundle for rlibs

    Fixes rust-lang#110912
    
    Checking `flavor == RlibFlavor::Normal` was accidentally lost in
    601fc8b
    rust-lang#105601
    
    That caused combining +whole-archive and +bundle link modifiers on
    non-rlib crates to fail with a confusing error message saying that
    combination is unstable for rlibs. In particular, this caused the
    build to fail when +whole-archive was used on staticlib crates, even
    though +whole-archive effectively does nothing on non-bin crates because
    the final linker invocation is left to an external build system.
    Be-ing committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    6a89e94 View commit details
    Browse the repository at this point in the history