Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

constify slice_as_chunks (unstable) #111453

Merged
merged 1 commit into from
May 20, 2023
Merged

Conversation

scottmcm
Copy link
Member

Tracking issue: #74985

Nothing complicated required; just adding const to the declarations.

@rustbot
Copy link
Collaborator

rustbot commented May 11, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 11, 2023
@rustbot
Copy link
Collaborator

rustbot commented May 11, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@Mark-Simulacrum
Copy link
Member

I'll go ahead and just approve since this is unstable and I think fairly obvious yes surface area.

@bors r+

@bors
Copy link
Contributor

bors commented May 18, 2023

📌 Commit 66eccac has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 18, 2023
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request May 18, 2023
…-Simulacrum

constify `slice_as_chunks` (unstable)

Tracking issue: rust-lang#74985

Nothing complicated required; just adding `const` to the declarations.
@Dylan-DPC
Copy link
Member

failed in rollup

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 18, 2023
@scottmcm
Copy link
Member Author

Ah, of course, #108273 won the race.

Tracking issue: 74985

Nothing complicated required; just adding `const` to the declarations.
@scottmcm
Copy link
Member Author

Yay, no lib.rs update needed now.

@bors r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented May 19, 2023

📌 Commit 62fcebd has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 19, 2023
@bors
Copy link
Contributor

bors commented May 19, 2023

⌛ Testing commit 62fcebd with merge 7047d97...

@bors
Copy link
Contributor

bors commented May 20, 2023

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 7047d97 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 20, 2023
@bors bors merged commit 7047d97 into rust-lang:master May 20, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 20, 2023
@scottmcm scottmcm deleted the constify-as-slice branch May 20, 2023 02:00
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (7047d97): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.5% [2.5%, 2.5%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 641.28s -> 640.962s (-0.05%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants