Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 7 pull requests #111719

Closed
wants to merge 15 commits into from
Closed

Rollup of 7 pull requests #111719

wants to merge 15 commits into from

Conversation

Dylan-DPC
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

cjgillot and others added 15 commits May 1, 2023 08:51
@cjgillot
Do not recover when parsing stmt in cfg-eval.
d56ce8e
@scottmcm
constify slice_as_chunks (unstable)
66eccac 
Tracking issue: 74985

Nothing complicated required; just adding `const` to the declarations.
@cjgillot
Retire is_foreign_item query.
37209dc
@Kobzol
Fix typo in bootstrap command description
90678cc
@cjgillot
Add incremental test.
222acaa
@cjgillot
Delay a bug when overwriting fed value.
3bb5d1d
@nnethercote
Remove unused impl<T> WorkerLocal<Vec<T>>.
9bfb90b
@Zoxc
Merge query property modules into one
f6c6d10
@Dylan-DPC
Rollup merge of rust-lang#110986 - cjgillot:delay-feed-bug, r=WaffleL…
8f2d75d 
…apkin

Delay a bug when overwriting fed value.

Fixes rust-lang#110887
@Dylan-DPC
Rollup merge of rust-lang#111054 - cjgillot:cfg-eval-recover, r=b-naber
a893695 
Do not recover when parsing stmt in cfg-eval.

`parse_stmt` does recovery on its own. When parsing the statement fails, we always get `Ok(None)` instead of an `Err` variant with the diagnostic that we can emit.

To avoid this behaviour, we need to opt-out of recovery for cfg_eval.

Fixes rust-lang#105228
@Dylan-DPC
Rollup merge of rust-lang#111453 - scottmcm:constify-as-slice, r=Mark…
62124da 
…-Simulacrum

constify `slice_as_chunks` (unstable)

Tracking issue: rust-lang#74985

Nothing complicated required; just adding `const` to the declarations.
@Dylan-DPC
Rollup merge of rust-lang#111685 - Kobzol:bootstrap-typo, r=clubby789
ae2ca1b 
Fix typo in bootstrap command description

Unless `duild` is some clever name for `dist build`, this is probably a typo.
@Dylan-DPC
Rollup merge of rust-lang#111686 - cjgillot:no-foreign-item, r=compil…
ac56b96 
…er-errors

Retire is_foreign_item query.

This can be written in terms of `DefKind`. This does not deserve the cost of a query.
@Dylan-DPC
Rollup merge of rust-lang#111703 - Zoxc:queries-mod, r=cjgillot
d2f5c98 
Merge query property modules into one

This merges all the query modules that defines types into a single module per query with a normal naming convention for type aliases.

r? `@cjgillot`
@Dylan-DPC
Rollup merge of rust-lang#111707 - nnethercote:rm-WorkerLocal-Vec, r=…
4edf329 
…compiler-errors

Remove unused `impl<T> WorkerLocal<Vec<T>>`.

cc `@SparrowLii` `@Zoxc`
@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels May 18, 2023
@Dylan-DPC
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented May 18, 2023

📌 Commit 4edf329 has been approved by Dylan-DPC

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 18, 2023
@rust-log-analyzer
Copy link
Collaborator

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
    |
156 | #![feature(const_slice_split_at_not_mut)]
    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `-D stable-features` implied by `-D warnings`
error: could not compile `core` (lib) due to previous error
Build completed unsuccessfully in 0:00:09

@Dylan-DPC
Copy link
Member Author

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 18, 2023
@Dylan-DPC Dylan-DPC mentioned this pull request May 18, 2023
Merged
@Dylan-DPC Dylan-DPC closed this May 18, 2023
@Dylan-DPC Dylan-DPC deleted the rollup-ss2zkyu branch May 18, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) rollup A PR which is a rollup S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Dylan-DPC @bors @rust-log-analyzer @rustbot @cjgillot @scottmcm @Kobzol @nnethercote @Zoxc