Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retire is_foreign_item query. #111686

Merged
merged 1 commit into from
May 18, 2023
Merged

Retire is_foreign_item query. #111686

merged 1 commit into from
May 18, 2023

Conversation

cjgillot
Copy link
Contributor

This can be written in terms of DefKind. This does not deserve the cost of a query.

@rustbot
Copy link
Collaborator

rustbot commented May 17, 2023

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 17, 2023
@compiler-errors
Copy link
Member

r? @compiler-errors @bors r+ rollup

@bors
Copy link
Contributor

bors commented May 17, 2023

📌 Commit 37209dc has been approved by compiler-errors

It is now in the queue for this repository.

@rustbot rustbot assigned compiler-errors and unassigned TaKO8Ki May 17, 2023
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 17, 2023
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request May 18, 2023
@Dylan-DPC
Rollup merge of rust-lang#111686 - cjgillot:no-foreign-item, r=compil…
ac56b96 
…er-errors

Retire is_foreign_item query.

This can be written in terms of `DefKind`. This does not deserve the cost of a query.
This was referenced May 18, 2023
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 18, 2023
@bors
Auto merge of rust-lang#111721 - Dylan-DPC:rollup-9jw6b7k, r=Dylan-DPC
fdd0301 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#110986 (Delay a bug when overwriting fed value.)
 - rust-lang#111054 (Do not recover when parsing stmt in cfg-eval.)
 - rust-lang#111685 (Fix typo in bootstrap command description)
 - rust-lang#111686 (Retire is_foreign_item query.)
 - rust-lang#111695 (Exclude inherent projections from some alias type `match`es)
 - rust-lang#111703 (Merge query property modules into one)
 - rust-lang#111707 (Remove unused `impl<T> WorkerLocal<Vec<T>>`.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ea6ac45 into rust-lang:master May 18, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 18, 2023
@cjgillot cjgillot deleted the no-foreign-item branch May 18, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
5 participants
@cjgillot @rustbot @compiler-errors @bors @TaKO8Ki