Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude inherent projections from some alias type matches #111695

Merged
merged 1 commit into from
May 18, 2023

Conversation

fmease
Copy link
Member

@fmease fmease commented May 17, 2023

Updating (hopefully) all remaining matches which I overlooked to update when adding AliasKind::Inherent in #109410.

Fixes #111399.
Sadly the regression test is a clippy test instead of a rustc one as I don't know of another way to test that a trait bound like Ty::InhProj: Trait doesn't cause a crash without reaching a cycle error first (this is getting old ^^').

@rustbot label F-inherent_associated_types
r? @compiler-errors

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels May 17, 2023
@rustbot
Copy link
Collaborator

rustbot commented May 17, 2023

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@rustbot rustbot added the F-inherent_associated_types `#![feature(inherent_associated_types)]` label May 17, 2023
@compiler-errors
Copy link
Member

r=me

@bors delegate+

@fmease fmease force-pushed the dont-lump-together-alias-tys branch from fabe138 to 2eee6cc Compare May 17, 2023 21:46
@fmease fmease force-pushed the dont-lump-together-alias-tys branch from 2eee6cc to 434f088 Compare May 17, 2023 21:54
@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented May 17, 2023

📌 Commit 434f088 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 17, 2023
@fmease
Copy link
Member Author

fmease commented May 17, 2023

Ah you were quicker 😆

bors added a commit to rust-lang-ci/rust that referenced this pull request May 18, 2023
Rollup of 7 pull requests

Successful merges:

 - rust-lang#110986 (Delay a bug when overwriting fed value.)
 - rust-lang#111054 (Do not recover when parsing stmt in cfg-eval.)
 - rust-lang#111685 (Fix typo in bootstrap command description)
 - rust-lang#111686 (Retire is_foreign_item query.)
 - rust-lang#111695 (Exclude inherent projections from some alias type `match`es)
 - rust-lang#111703 (Merge query property modules into one)
 - rust-lang#111707 (Remove unused `impl<T> WorkerLocal<Vec<T>>`.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d2823a1 into rust-lang:master May 18, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 18, 2023
@fmease fmease deleted the dont-lump-together-alias-tys branch May 18, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F-inherent_associated_types `#![feature(inherent_associated_types)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: clippy: inherent_associated_types item_bounds called on DefId(0:6 ~ ambiguous_inherent_assoc_ty
4 participants