Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that missing_copy_implementations and missing_debug_implementations only apply to public items. #111572

Merged
merged 1 commit into from
May 16, 2023

Conversation

kpreid
Copy link
Contributor

@kpreid kpreid commented May 14, 2023

I encountered #111359 (fixed) and noticed that the documentation didn't say that it was intended that missing_debug_implementations only applies to public items. This PR fixes that, and makes the same wording change to missing_copy_implementations which has the same condition.

I chose the words to also be similar to missing_docs which already had such a remark.

@rustbot
Copy link
Collaborator

rustbot commented May 14, 2023

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 14, 2023
@compiler-errors
Copy link
Member

Yeah, #111359 (comment) says the lint should be restricted to nominally pub items, so this looks fine.

r? @compiler-errors @bors r+ rollup

@bors
Copy link
Contributor

bors commented May 15, 2023

📌 Commit 980b392 has been approved by compiler-errors

It is now in the queue for this repository.

@rustbot rustbot assigned compiler-errors and unassigned TaKO8Ki May 15, 2023
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 15, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 15, 2023
Document that `missing_copy_implementations` and `missing_debug_implementations` only apply to public items.

I encountered rust-lang#111359 (fixed) and noticed that the documentation didn't say that it was _intended_ that `missing_debug_implementations` only applies to public items. This PR fixes that, and makes the same wording change to `missing_copy_implementations` which has the same condition.

I chose the words to also be similar to `missing_docs` which already had such a remark.
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request May 16, 2023
Document that `missing_copy_implementations` and `missing_debug_implementations` only apply to public items.

I encountered rust-lang#111359 (fixed) and noticed that the documentation didn't say that it was _intended_ that `missing_debug_implementations` only applies to public items. This PR fixes that, and makes the same wording change to `missing_copy_implementations` which has the same condition.

I chose the words to also be similar to `missing_docs` which already had such a remark.
Noratrieb added a commit to Noratrieb/rust that referenced this pull request May 16, 2023
Document that `missing_copy_implementations` and `missing_debug_implementations` only apply to public items.

I encountered rust-lang#111359 (fixed) and noticed that the documentation didn't say that it was _intended_ that `missing_debug_implementations` only applies to public items. This PR fixes that, and makes the same wording change to `missing_copy_implementations` which has the same condition.

I chose the words to also be similar to `missing_docs` which already had such a remark.
Noratrieb added a commit to Noratrieb/rust that referenced this pull request May 16, 2023
Document that `missing_copy_implementations` and `missing_debug_implementations` only apply to public items.

I encountered rust-lang#111359 (fixed) and noticed that the documentation didn't say that it was _intended_ that `missing_debug_implementations` only applies to public items. This PR fixes that, and makes the same wording change to `missing_copy_implementations` which has the same condition.

I chose the words to also be similar to `missing_docs` which already had such a remark.
bors added a commit to rust-lang-ci/rust that referenced this pull request May 16, 2023
Rollup of 10 pull requests

Successful merges:

 - rust-lang#111428 (refactor(resolve): clean up the early error return caused by non-call)
 - rust-lang#111449 (Recover `impl<T ?Sized>` correctly)
 - rust-lang#111572 (Document that `missing_copy_implementations` and `missing_debug_implementations` only apply to public items.)
 - rust-lang#111602 (Suppress "erroneous constant used" for constants tainted by errors)
 - rust-lang#111605 (fixup version placeholder for `cfi_encoding` feature)
 - rust-lang#111607 (Add clubby789 to the bootstrap review rotation)
 - rust-lang#111614 (Add more interesting nonsense to weird-exprs.rs)
 - rust-lang#111617 (Fixed typo)
 - rust-lang#111620 (Add eholk back to compiler-contributors reviewers)
 - rust-lang#111621 (Fix release date of 1.58.1 in release notes.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f6da357 into rust-lang:master May 16, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 16, 2023
@kpreid kpreid deleted the mdi branch August 29, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants