Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eholk back to compiler-contributors reviewers #111620

Merged
merged 1 commit into from
May 16, 2023

Conversation

eholk
Copy link
Contributor

@eholk eholk commented May 15, 2023

@eholk is back from vacation so he can review things again.

r? @wesleywiser

@eholk is back from vacation so he can review things again.
@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 15, 2023
@wesleywiser
Copy link
Member

Thanks Eric! 🥇

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 15, 2023

📌 Commit c11fd92 has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 15, 2023
Noratrieb added a commit to Noratrieb/rust that referenced this pull request May 16, 2023
…wesleywiser

Add eholk back to compiler-contributors reviewers

`@eholk` is back from vacation so he can review things again.

r? `@wesleywiser`
Noratrieb added a commit to Noratrieb/rust that referenced this pull request May 16, 2023
…wesleywiser

Add eholk back to compiler-contributors reviewers

``@eholk`` is back from vacation so he can review things again.

r? ``@wesleywiser``
bors added a commit to rust-lang-ci/rust that referenced this pull request May 16, 2023
Rollup of 10 pull requests

Successful merges:

 - rust-lang#111428 (refactor(resolve): clean up the early error return caused by non-call)
 - rust-lang#111449 (Recover `impl<T ?Sized>` correctly)
 - rust-lang#111572 (Document that `missing_copy_implementations` and `missing_debug_implementations` only apply to public items.)
 - rust-lang#111602 (Suppress "erroneous constant used" for constants tainted by errors)
 - rust-lang#111605 (fixup version placeholder for `cfi_encoding` feature)
 - rust-lang#111607 (Add clubby789 to the bootstrap review rotation)
 - rust-lang#111614 (Add more interesting nonsense to weird-exprs.rs)
 - rust-lang#111617 (Fixed typo)
 - rust-lang#111620 (Add eholk back to compiler-contributors reviewers)
 - rust-lang#111621 (Fix release date of 1.58.1 in release notes.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 607ed89 into rust-lang:master May 16, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants