Remove constness from TraitPredicate

[fee1-dead]

Any ICEs or compiler errors created by this PR are expected and intended to be fixed in the future.

r? @oli-obk
cc #110395

[rustbot]

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

Some changes occurred in engine.rs, potentially modifying the public API of ObligationCtxt.

cc @lcnr, @compiler-errors

[oli-obk]

should we just remove the code instead of leaving it commented out? Can always recover it from history

[oli-obk]

probably needs to wait until the pretty printing PR lands?

[fee1-dead]

probably needs to wait until the pretty printing PR lands?

I mean I think this is orthogonal to #114203? Git should know to perform a three-way merge and since these PRs don't modify the same places on the same file it should be fine

[fee1-dead]

@oli-obk is this good to go now?

[oli-obk]

@bors r+

[bors]

📌 Commit 39e556bb635256eb8eb2952913447c9f7b60a026 has been approved by oli-obk

It is now in the queue for this repository.

[bors]

☔ The latest upstream changes (presumably #114310) made this pull request unmergeable. Please resolve the merge conflicts.

[oli-obk]

r=me after CI golf succeeds and commits are squashed

[fee1-dead]

@bors r=oli-obk

[bors]

📌 Commit 44793d008f2a5af80666092abf20c358f137f836 has been approved by oli-obk

It is now in the queue for this repository.

[bors]

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

1. git checkout rm-constness-2 (switch to your branch)
2. git fetch upstream master (retrieve the latest master)
3. git rebase upstream/master -p (rebase on top of it)
4. Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
5. git push self rm-constness-2 --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message

Removing tests/ui/rfcs/rfc-2632-const-trait-impl/specialization/const-default-bound-non-const-specialized-bound.stderr
Auto-merging compiler/rustc_ty_utils/src/ty.rs
CONFLICT (content): Merge conflict in compiler/rustc_ty_utils/src/ty.rs
Auto-merging compiler/rustc_trait_selection/src/traits/select/mod.rs
Auto-merging compiler/rustc_trait_selection/src/traits/error_reporting/mod.rs
Auto-merging compiler/rustc_middle/src/ty/structural_impls.rs
Auto-merging compiler/rustc_hir_analysis/src/check/wfcheck.rs
Auto-merging compiler/rustc_hir_analysis/src/astconv/mod.rs
Automatic merge failed; fix conflicts and then commit the result.

[bors]

☔ The latest upstream changes (presumably #114358) made this pull request unmergeable. Please resolve the merge conflicts.

[fee1-dead]

Rebased.

@bors p=1 r=oli-obk

Bitrotty

[bors]

📌 Commit 4fec845 has been approved by oli-obk

It is now in the queue for this repository.

[bors]

⌛ Testing commit 4fec845 with merge 20747af...

[bors]

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 20747af to master...

[rust-timer]

Finished benchmarking commit (20747af): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.7%	[-0.9%, -0.4%]	16
Improvements ✅ (secondary)	-0.6%	[-1.2%, -0.3%]	13
All ❌✅ (primary)	-0.7%	[-0.9%, -0.4%]	16

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-2.4%	[-3.3%, -1.5%]	2
Improvements ✅ (secondary)	-2.2%	[-3.4%, -0.9%]	2
All ❌✅ (primary)	-2.4%	[-3.3%, -1.5%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.4%	[-2.4%, -2.4%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.4%	[-2.4%, -2.4%]	1

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.0%	[-0.1%, -0.0%]	16
Improvements ✅ (secondary)	-0.1%	[-0.2%, -0.0%]	21
All ❌✅ (primary)	-0.0%	[-0.1%, -0.0%]	16

Bootstrap: 649.933s -> 650.695s (0.12%)