Update Clippy #114310
Merged
Update Clippy #114310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it trim the contents
…1995 Update bug URL to use the ice template The previous URL linked to the blank new issue from without any template. This will now link to the ICE template :) * Before: https://github.com/rust-lang/rust-clippy/issues/new * After: https://github.com/rust-lang/rust-clippy/issues/new?template=ice.yml That's it, nothing too interesting besides that. For everyone reading this: here, have some free cream 🍨 🍦 and have a beautiful day. 🙃 changelog: none
[`semicolon_if_nothing_returned`]: add an autofix changelog: [`semicolon_if_nothing_returned`]: add an autofix
…sery, r=xFrednet Move tuple_array_conversions to nursery changelog: Move [`tuple_array_conversions`] to `nursery` (Now allow-by-default) <!-- FIY: Ignore this change, if the commit gets backported and also rust-lang/rust-clippy#11146 --> [rust-lang#11172](rust-lang/rust-clippy#11172) The nursery change got lost in rust-lang#11146 and it ended up in pedantic, this puts it in nursery and gives something to backport r? `@xFrednet`
new lint: `format_collect` A perf lint that looks for `format!`ing inside of `map`, then collecting it into a `String`. Did a quick benchmark locally and it's a bit more than 2x faster with fold. `write!` is still not optimal (presumably because the fmt stuff goes through dynamic dispatch), but it's still a lot better than creating a new string on every element. I thought about making a machine applicable suggestion, but there's a lot of suggestions that need to be made here, so I decided to just add help messages. changelog: new lint: `format_collect`
…=Manishearth Don't lint `needless_return` in fns across a macro boundary Fixes rust-lang#11167 changelog: none
…ogiq Rewrite [`tuple_array_conversions`] Fixes rust-lang#11100 Fixes rust-lang#11144 Fixes rust-lang#11124 rust-lang#11082 still needs discussion and rust-lang#11085 likely can't be fixed. changelog: [`tuple_array_conversions`]: Move to `pedantic` changelog: [`tuple_array_conversions`]: Don't lint if mutability of references changes changelog: [`tuple_array_conversions`]: Don't lint if bindings don't come from the exact same pattern changelog: [`tuple_array_conversions`]: Don't lint if bindings are used for more than just the conversion
New lint [`four_forward_slashes`] Closes rust-lang#9212 changelog: New lint [`four_forward_slashes`]
Improve debug assertions for `make_projection`
* Better track when a early-bound region appears when a late-bound region is required * Don't lint when the closure gives explicit types.
`redundant_closure` fixes fixes rust-lang#8548 A good chunk of the code is fixing false negatives. The old code banned any non late-bound regions from appearing in the callee's signature. The new version checks when the late-bound region is actually required. changelog: Better track when a early-bound region appears when a late-bound region is required in `redundant_closure`. changelog: Don't lint `redundant_closure` when the closure gives explicit types.
Resolve type aliases in `type_certainty` Fixes rust-lang#11256 changelog: `unwrap_or_default`: Fix ICE when local types are declared using alias types
[`unnecessary_find_map`]: look for then_some Closes rust-lang#11260 changelog: [`unnecessary_find_map`]: lint `.then_some()` in closure
[`arithmetic_side_effects`] Fix rust-lang#11262 Fix rust-lang#11262 Rustc already handles paths that refer literals -> https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=d795058a2e1634c867288c20ff9432c8 ``` changelog: [`arithmetic_side_effects`]: Ignore paths that refer literals ```
rustbot
added
the
S-waiting-on-review
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
|
@bors r+ p=1 rollup=never thanks! |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This was referenced Aug 1, 2023
|
Finished benchmarking commit (b484c87): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 651.969s -> 649.854s (-0.32%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Manishearth
This is a bit delayed, because I thought it is a difficult conflict resolution and didn't have time for that over the weekend. Turns out, I just used the wrong merge base and it was actually easy... Don't do syncs in the middle of the night (even though I broke this rule with this PR again).