Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

offset_of: guard against invalid use (with unsized fields) #114614

Merged
merged 1 commit into from
Aug 10, 2023
Merged

offset_of: guard against invalid use (with unsized fields) #114614

merged 1 commit into from
Aug 10, 2023

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Aug 8, 2023

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Aug 8, 2023

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 8, 2023
@cjgillot
Copy link
Contributor

cjgillot commented Aug 9, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Aug 9, 2023

📌 Commit 9215346 has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 10, 2023
@matthiaskrgr
Rollup merge of rust-lang#114614 - RalfJung:offset-of-sanity, r=cjgillot
f059e6e 
offset_of: guard against invalid use (with unsized fields)
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 10, 2023
Closed
@bors
Copy link
Contributor

bors commented Aug 10, 2023

⌛ Testing commit 9215346 with merge 307c573...

@bors
Copy link
Contributor

bors commented Aug 10, 2023

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing 307c573 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 10, 2023
@bors bors merged commit 307c573 into rust-lang:master Aug 10, 2023
11 checks passed
@rustbot rustbot added this to the 1.73.0 milestone Aug 10, 2023
@bors bors mentioned this pull request Aug 10, 2023
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (307c573): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 632.664s -> 632.004s (-0.10%)

@RalfJung RalfJung deleted the offset-of-sanity branch August 15, 2023 06:17
@GrigorenkoPV GrigorenkoPV mentioned this pull request Mar 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cjgillot cjgillot

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.
5 participants
@RalfJung @rustbot @cjgillot @bors @rust-timer