Rollup of 7 pull requests #114686
Closed
Rollup of 7 pull requests #114686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ozkanonur <work@onurozkan.dev>
this ICE was caused by `transform_ty` in compiler/rustc_symbol_mangling/src/typeid/typeid_itanium_cxx_abi.rs encountering an unevaluated const, while expecting it to already be evaluated. add a regression test Update tests/ui/sanitize/issue-114275-cfi-const-expr-in-arry-len.rs Co-authored-by: Michael Goulet <michael@errs.io> Update tests/ui/sanitize/issue-114275-cfi-const-expr-in-arry-len.rs Co-authored-by: Michael Goulet <michael@errs.io>
…m/array/tuple literals unless *all* sub-expressions had side effects. This would easily allow side effects to slip through, and also wrongly label empty literals as having side effects. Add some tests for the last point
Just remove a typo.
…-config, r=clubby789 better error handling for `rust.codegen-backends` on deserialization Fixes rust-lang#109315
…errors Detect missing `;` that parses as function call Fix rust-lang#106515.
offset_of: guard against invalid use (with unsized fields)
make `typeid::typeid_itanium_cxx_abi::transform_ty` evaluate length in array types the ICE in rust-lang#114275 was caused by `transform_ty` in compiler/rustc_symbol_mangling/src/typeid/typeid_itanium_cxx_abi.rs encountering an unevaluated const, while expecting it to already be evaluated.
…ler-errors Add clubby789 to `users_on_vacation` I'm on holiday until the 30th of August so won't be able to take on reviews until then
…fects, r=compiler-errors `Expr::can_have_side_effects()` is incorrect for struct/enum/array/tuple literals It would return 'false' unless *all* sub-expressions had side effects. This would easily allow side effects to slip through, and also wrongly label empty literals as having side effects. Add some tests for the last point The function is only used for simple lints and error messages, so not a serious bug.
doc (unstable-book): fix a typo Just fix a small typo.
rustbot
added
A-meta
|
@bors r+ rollup=never p=7 |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 7ebf771 with merge 68910f9061ebb3034809ec9c3f14e382591cfa6a... |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
lenawanel
added a commit
to lenawanel/rust
that referenced
this pull request
Aug 10, 2023
this ICE was caused by `transform_ty` in compiler/rustc_symbol_mangling/src/typeid/typeid_itanium_cxx_abi.rs encountering an unevaluated const, while expecting it to already be evaluated. add a regression test Update tests/ui/sanitize/issue-114275-cfi-const-expr-in-arry-len.rs Co-authored-by: Michael Goulet <michael@errs.io> Update tests/ui/sanitize/issue-114275-cfi-const-expr-in-arry-len.rs Co-authored-by: Michael Goulet <michael@errs.io> fix test compiling for targets with -crt-static and failing this was causign rust-lang#114686 to fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
rust.codegen-backendson deserialization #114278 (better error handling forrust.codegen-backendson deserialization);that parses as function call #114474 (Detect missing;that parses as function call)typeid::typeid_itanium_cxx_abi::transform_tyevaluate length in array types #114672 (maketypeid::typeid_itanium_cxx_abi::transform_tyevaluate length in array types)users_on_vacation#114674 (Add clubby789 tousers_on_vacation)Expr::can_have_side_effects()is incorrect for struct/enum/array/tuple literals #114678 (Expr::can_have_side_effects()is incorrect for struct/enum/array/tuple literals)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup