Dummy PR to test coverage test changes in CI #114917

Zalathar · 2023-08-17T00:19:58Z

The x86_64-gnu-llvm-15 job that normally runs on PRs doesn't include the profiler runtime, so most of the coverage tests don't get run on PRs.

(That's why #114875 didn't fail until an actual merge was attempted.)

r? @ghost

Zalathar · 2023-08-17T00:20:24Z

@rustbot experimental

Zalathar · 2023-08-17T00:20:47Z

@rustbot author

Zalathar · 2023-08-17T01:55:26Z

Success!

https://github.com/rust-lang/rust/actions/runs/5885191281

Zalathar · 2023-08-17T02:14:13Z

Now testing #114843 in CI on Linux/Windows/macOS, to ensure I don't get any nasty surprises after it's reviewed.

Zalathar · 2023-08-17T05:09:14Z

Success:

bors · 2023-08-29T20:14:52Z

☔ The latest upstream changes (presumably #115183) made this pull request unmergeable. Please resolve the merge conflicts.

Zalathar · 2023-09-02T00:10:05Z

Testing #114843 on Linux/Windows/macOS (coverage-map and run-coverage only), to see if everything still works on the big 3 configurations.

Zalathar · 2023-09-02T00:29:55Z

Those Linux failures look like the same ones I saw on the aarch64-gnu build, so hopefully that's a platform issue and I don't have to worry about ARM Linux specifically.

I'm going to try another run of Windows only, to flush out any unknown issues on that platform.

Zalathar · 2023-09-02T01:23:23Z

Test failures on Windows seem to be the same as the Linux ones, which is surprising.

Perhaps there is some common property of the main Linux/Windows CI environments that is not shared by x86_64-gnu-llvm-15 or my local Aarch64 macOS environment.

Zalathar · 2023-09-02T01:24:24Z

I'll try a CI macOS build to double check all the major platforms.

Zalathar · 2023-09-02T02:34:03Z

Hmm, so the overall results so far seem to be:

Failure (probably the same failures, though I haven't fully verified this):

aarch64-gnu
x86_64-gnu
x86_64-msvc
x86_64-apple-1

Success:

x86_64-gnu-llvm-15
Local build on aarch64 macOS
Local build on aarch64 macOS (--stage=2)

Zalathar · 2023-09-02T02:36:37Z

Trying another build with the default PR CI config (x86_64-gnu-llvm-15) just to confirm again that that one still works.

bors · 2024-06-24T14:20:25Z

☔ The latest upstream changes (presumably #126788) made this pull request unmergeable. Please resolve the merge conflicts.

Zalathar · 2024-08-24T10:03:33Z

Successful jobs:

bors · 2024-08-25T17:18:03Z

☔ The latest upstream changes (presumably #129295) made this pull request unmergeable. Please resolve the merge conflicts.

This also migrates from legacy `cargo:` directives to the newer `cargo::` prefix.

This file was introduced in LLVM 11, but was then removed in LLVM 13.

The whole file is surrounded by `#if defined(_WIN32)`, so there's no need to have separate logic to exclue it from non-Windows builds.

Now that the list of source files has been cleaned up, we can reasonably expect _all_ of the listed source files to be present.

bors · 2024-09-19T00:38:39Z

☔ The latest upstream changes (presumably #130534) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 17, 2023

Zalathar force-pushed the dummy-coverage branch from 77baf81 to 4363ce9 Compare August 17, 2023 02:13

Zalathar force-pushed the dummy-coverage branch 2 times, most recently from b605cc7 to c4511d7 Compare September 2, 2023 00:08