Rollup of 9 pull requests

[workingjubilee]

Successful merges:

• Add Thread::{into_raw, from_raw} #97524 (Add Thread::{into_raw, from_raw})
• Do not ICE with incorrect empty suggestion #127988 (Do not ICE with incorrect empty suggestion)
• Gate repr(Rust) correctly on non-ADT items #129422 (Gate repr(Rust) correctly on non-ADT items)
• Win: Open dir for sync access in remove_dir_all #129934 (Win: Open dir for sync access in remove_dir_all)
• Reduce confusion about make_indirect_byval by renaming it #130450 (Reduce confusion about make_indirect_byval by renaming it)
• Implement ACP 429: add Lazy{Cell,Lock}::get[_mut] and force_mut #130476 (Implement ACP 429: add Lazy{Cell,Lock}::get[_mut] and force_mut)
• Update the minimum external LLVM to 18 #130487 (Update the minimum external LLVM to 18)
• Clarify docs for std::fs::File::write #130513 (Clarify docs for std::fs::File::write)
• [Clippy] Swap manual_retain to use diagnostic items instead of paths #130522 ([Clippy] Swap manual_retain to use diagnostic items instead of paths)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[workingjubilee]

@bors r+ rollup=never p=9

[bors]

📌 Commit 4bd9de5 has been approved by workingjubilee

It is now in the queue for this repository.

[bors]

⌛ Testing commit 4bd9de5 with merge a5cf8bb...

[bors]

☀️ Test successful - checks-actions
Approved by: workingjubilee
Pushing a5cf8bb to master...

[rust-timer]

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#97524	Add Thread::{into_raw, from_raw}	bb573de65117308851e29a781e182c5b274951f6 (link)
#127988	Do not ICE with incorrect empty suggestion	4e8b520aee90fd7b05dfb480506db17b210720da (link)
#129422	Gate repr(Rust) correctly on non-ADT items	ff533dd4997b5bd7552706efaa6f310c86b314b1 (link)
#129934	Win: Open dir for sync access in remove_dir_all	37d3b06e43db3a3f1cb7c5bfdd9626aac128661c (link)
#130450	Reduce confusion about make_indirect_byval by renaming it	282ec54e95e8ab718b61b02a7c3c975a80f7e937 (link)
#130476	Implement ACP 429: add Lazy{Cell,Lock}::get[_mut] and `fo…	2287c30afc91b7a59bfcabbc4755e5f2b65ad217 (link)
#130487	Update the minimum external LLVM to 18	fe489e4066f934b7df6551d1918207bda180f5fe (link)
#130513	Clarify docs for std::fs::File::write	8a3110b6ba95b32d019613d9494ddddbc6f5a06b (link)
#130522	[Clippy] Swap manual_retain to use diagnostic items inste…	6b0efb20d021657f99b962b1ce550b9ef1732255 (link)

previous master: f79a912d9e

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

[rust-timer]

Finished benchmarking commit (a5cf8bb): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.2%, 0.3%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.1%	[-1.2%, -0.6%]	4
All ❌✅ (primary)	0.3%	[0.2%, 0.3%]	3

Max RSS (memory usage)

Results (secondary 0.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.9%	[0.7%, 3.2%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.3%	[-2.3%, -2.3%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary 2.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.9%	[2.9%, 2.9%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

Results (primary -0.3%, secondary -1.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-0.3%, -0.3%]	3
Improvements ✅ (secondary)	-1.1%	[-1.1%, -1.1%]	3
All ❌✅ (primary)	-0.3%	[-0.3%, -0.3%]	3

Bootstrap: 769.338s -> 766.835s (-0.33%)
Artifact size: 341.29 MiB -> 341.29 MiB (-0.00%)

[pnkfelix]

• syn regressed on three variant profiles: check incr-unchanged (-0.28%), check incr-patched:println (-0.27%), and debug incr-unchanged (-0.23%)
• detailed perf results indicates that incr_comp_persist_dep_graph went from 0.002 seconds to 0.14 seconds; a delta that accounts for the vast bulk of the difference here...
• but from examining the PR's that follow, it doesn't seem like that result persists into the future. (Also, I'm realizing that the detailed results are presenting seconds, not instruction-counts, and therefore they are probably wildly unstable between runs...)
• marking as triaged; this isn't worth investigating further.

@rustbot label: +perf-regression-triaged