Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some additional region refactorings #117944

Merged
merged 2 commits into from
Nov 17, 2023
Merged

some additional region refactorings #117944

merged 2 commits into from
Nov 17, 2023

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Nov 15, 2023

the commits are selfcontained ✨

r? @BoxyUwU

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 15, 2023
@rustbot
Copy link
Collaborator

rustbot commented Nov 15, 2023

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@BoxyUwU
Copy link
Member

BoxyUwU commented Nov 15, 2023

r=me if CI passes

@compiler-errors
Copy link
Member

@bors r=BoxyUwU

@bors
Copy link
Contributor

bors commented Nov 16, 2023

📌 Commit cf77639 has been approved by BoxyUwU

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 16, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 16, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 17, 2023
@bors
Auto merge of rust-lang#117996 - matthiaskrgr:rollup-sp48bl4, r=matth…
f2f526c 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#117892 (Detect more `=>` typos)
 - rust-lang#117959 (Better handle type errors involving `Self` literals)
 - rust-lang#117980 (fix: Update CONTRIBUTING.md recommend -> recommended)
 - rust-lang#117982 (bootstrap: only show PGO warnings when verbose)
 - rust-lang#117990 (Tweak error and move tests)

Failed merges:

 - rust-lang#117944 (some additional region refactorings)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Contributor

bors commented Nov 17, 2023

☔ The latest upstream changes (presumably #117979) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 17, 2023
@rustbot
Copy link
Collaborator

rustbot commented Nov 17, 2023

Some changes occurred in src/tools/cargo

cc @ehuss

@lcnr
rename bound region instantiation
40b154e 
- `erase_late_bound_regions` -> `instantiate_bound_regions_with_erased`
- `replace_late_bound_regions_X` -> `instantiate_bound_regions_X`
@lcnr
Copy link
Contributor Author

lcnr commented Nov 17, 2023

added cargo to the second commit by accident

@lcnr
Copy link
Contributor Author

lcnr commented Nov 17, 2023

@bors r=BoxyUwU

@bors
Copy link
Contributor

bors commented Nov 17, 2023

📌 Commit 40b154e has been approved by BoxyUwU

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 17, 2023
@bors
Copy link
Contributor

bors commented Nov 17, 2023

⌛ Testing commit 40b154e with merge 069a4af...

@bors
Copy link
Contributor

bors commented Nov 17, 2023

☀️ Test successful - checks-actions
Approved by: BoxyUwU
Pushing 069a4af to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 17, 2023
@bors bors merged commit 069a4af into rust-lang:master Nov 17, 2023
12 checks passed
@rustbot rustbot added this to the 1.76.0 milestone Nov 17, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (069a4af): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.1% [0.1%, 0.1%] 1
Regressions ❌
(secondary)		 0.4% [0.3%, 1.0%] 10
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.1% [0.1%, 0.1%] 1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.8% [0.5%, 1.1%] 2
Regressions ❌
(secondary)		 2.8% [1.3%, 3.6%] 4
Improvements ✅
(primary)		 -0.8% [-1.3%, -0.5%] 3
Improvements ✅
(secondary)		 -1.2% [-1.2%, -1.2%] 2
All ❌✅ (primary) -0.2% [-1.3%, 1.1%] 5

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.5% [2.3%, 2.8%] 3
Regressions ❌
(secondary)		 4.1% [2.0%, 6.8%] 8
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 2.5% [2.3%, 2.8%] 3

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 676.352s -> 676.162s (-0.03%)
Artifact size: 313.63 MiB -> 313.62 MiB (-0.00%)

@rustbot rustbot added the perf-regression Performance regression. label Nov 17, 2023
@lcnr lcnr deleted the region-refactor-uwu branch November 20, 2023 11:36
@Mark-Simulacrum
Copy link
Member

Regressions appear to be genuine but are mostly limited to secondary benchmarks. Not worth further investigation, I think.

@Mark-Simulacrum Mark-Simulacrum added the perf-regression-triaged The performance regression has been triaged. label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@BoxyUwU BoxyUwU

Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.
7 participants
@lcnr @rustbot @BoxyUwU @compiler-errors @bors @rust-timer @Mark-Simulacrum