Clippy subtree sync #117979
Merged
Clippy subtree sync #117979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most notably, this commit changes the `pub use crate::*;` in that file to `use crate::*;`. This requires a lot of `use` items in other crates to be adjusted, because everything defined within `rustc_span::*` was also available via `rustc_span::source_map::*`, which is bizarre. The commit also removes `SourceMap::span_to_relative_line_string`, which is unused.
…dnet Fix `dbg_macro` semi span calculation `span_including_semi` was using a `BytePos` to index into a file's source which happened to work because the root file of the test started at `BytePos` 0, it didn't work for other files changelog: none
`rustc_span` cleanups Just some things I found while looking over this crate. r? `@oli-obk`
[`unused_enumerate_index`]: don't ICE on empty tuples Fixes rust-lang#11755 changelog: [`unused_enumerate_index`]: don't ICE on empty tuples I'm going to nominate for beta backport because the code that is needed to trigger this seems likely to occur in real code `@rustbot` label +beta-nominated
update references of old `msrvs` and `conf` paths In rust-lang#11685, `clippy_lints::utils::conf` and `clippy_utils::msrvs` were moved to a separate `clippy_config` crate. I noticed that not all references to those paths were updated, so this small PR intends to fix those. changelog: none
Make SpanlessEq more consistent 1) Remove wildcard as requested in rust-lang/rust-clippy#10267. 2) Implement `hir_utils::eq_expr` for `ExprKind::Closure`, `ExprKind::ConstBlock`, `ExprKind::InlineAsm` and `ExprKind::Yield`. 3) Reorder branches of `hir_utils::eq_expr` to be in alphabetical order. --- changelog: none
Fixes: rust-lang#11714 changelog: [`arc_with_non_send_sync`]: Suggest RC over unsafe impl Co-authored-by: Alejandra González <blyxyas@gmail.com>
[arc_with_non_send_sync] Improve suggested resolution Fixes: rust-lang#11714 Improved the lint message for [`arc_with_non_send_sync`] to suggest using `RC` unless user needs an Arc, then suggests wrapping in a mutex, and then suggests implementing `Sync` and `Send`. --- changelog: [`arc_with_non_send_sync`]: Suggest RC over unsafe impl of Send and Sync
fixes: rust-lang#11775 current state: indiscriminately emits the lint for mod files in tests. The following tests/ common/ mod.rs test.rs is a common pattern for code shared across the tests and is suggested in the rust book. The change adds an additional check to verify that the mod file is not in tests. changelog: Fix [`mod_module_files`]: false positive for mod files in tests folder
[`mod_module_files`] Don't emit lint for mod.rs in tests fixes: rust-lang#11775 current state: indiscriminately emits the lint for mod files in tests. The following ``` tests/ common/ mod.rs test.rs ``` is a common pattern for code shared across the tests and is suggested in the rust book. The change adds an additional check to verify that the mod file is not in tests. changelog: Fix [`mod_module_files`]: false positive for mod files in tests folder
Rustup r? `@ghost` changelog: none
rustbot
added
the
S-waiting-on-review
|
@bors r+ p=1 |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 16, 2023
Clippy subtree sync r? `@Manishearth`
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry network problems again |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This was referenced Nov 16, 2023
|
Finished benchmarking commit (a577704): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 675.791s -> 676.528s (0.11%) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Manishearth