Add new targets {x86_64,i686}-win7-windows-msvc #118150

roblabla · 2023-11-21T22:06:18Z

This PR adds two new Tier 3 targets, x86_64-win7-windows-msvc and i686-win7-windows-msvc, that aim to support targeting Windows 7 after the *-pc-windows-msvc target drops support for it (slated to happen in 1.76.0).

Tier 3 target policy

At this tier, the Rust project provides no official support for a target, so we place minimal requirements on the introduction of targets.

A proposed new tier 3 target must be reviewed and approved by a member of the compiler team based on these requirements. The reviewer may choose to gauge broader compiler team consensus via a Major Change Proposal (MCP).

A proposed target or target-specific patch that substantially changes code shared with other targets (not just target-specific code) must be reviewed and approved by the appropriate team for that shared code before acceptance.

A tier 3 target must have a designated developer or developers (the "target maintainers") on record to be CCed when issues arise regarding the target. (The mechanism to track and CC such developers may evolve over time.)

This is me, @roblabla on github.

Targets must use naming consistent with any existing targets; for instance, a target for the same CPU or OS as an existing Rust target should use the same name for that CPU or OS. Targets should normally use the same names and naming conventions as used elsewhere in the broader ecosystem beyond Rust (such as in other toolchains), unless they have a very good reason to diverge. Changing the name of a target can be highly disruptive, especially once the target reaches a higher tier, so getting the name right is important even for a tier 3 target.

I went with naming the target x86_64-win7-windows-msvc, inserting the win7 in the vendor field (usually set to to pc). This is done to avoid ecosystem churn, as quite a few crates have cfg(target_os = "windows") or cfg(target_env = "msvc"), but nearly no cfg(target_vendor = "pc"). Since my goal is to be able to seamlessly swap to the win7 target, I figured it'd be easier this way.

Target names should not introduce undue confusion or ambiguity unless absolutely necessary to maintain ecosystem compatibility. For example, if the name of the target makes people extremely likely to form incorrect beliefs about what it targets, the name should be changed or augmented to disambiguate it.

I believe the naming is pretty explicit.

If possible, use only letters, numbers, dashes and underscores for the name. Periods (.) are known to cause issues in Cargo.

The name comforms to this requirement.

Tier 3 targets may have unusual requirements to build or use, but must not create legal issues or impose onerous legal terms for the Rust project or for Rust developers or users.

The target must not introduce license incompatibilities.

Anything added to the Rust repository must be under the standard Rust license (MIT OR Apache-2.0).

The target must not cause the Rust tools or libraries built for any other host (even when supporting cross-compilation to the target) to depend on any new dependency less permissive than the Rust licensing policy. This applies whether the dependency is a Rust crate that would require adding new license exceptions (as specified by the tidy tool in the rust-lang/rust repository), or whether the dependency is a native library or binary. In other words, the introduction of the target must not cause a user installing or running a version of Rust or the Rust tools to be subject to any new license requirements.

Compiling, linking, and emitting functional binaries, libraries, or other code for the target (whether hosted on the target itself or cross-compiling from another target) must not depend on proprietary (non-FOSS) libraries. Host tools built for the target itself may depend on the ordinary runtime libraries supplied by the platform and commonly used by other applications built for the target, but those libraries must not be required for code generation for the target; cross-compilation to the target must not require such libraries at all. For instance, rustc built for the target may depend on a common proprietary C runtime library or console output library, but must not depend on a proprietary code generation library or code optimization library. Rust's license permits such combinations, but the Rust project has no interest in maintaining such combinations within the scope of Rust itself, even at tier 3.

"onerous" here is an intentionally subjective term. At a minimum, "onerous" legal/licensing terms include but are not limited to: non-disclosure requirements, non-compete requirements, contributor license agreements (CLAs) or equivalent, "non-commercial"/"research-only"/etc terms, requirements conditional on the employer or employment of any particular Rust developers, revocable terms, any requirements that create liability for the Rust project or its developers or users, or any requirements that adversely affect the livelihood or prospects of the Rust project or its developers or users.

As far as I understand it, this target has exactly the same legal situation as the existing Tier 1 x86_64-pc-windows-msvc.

Neither this policy nor any decisions made regarding targets shall create any binding agreement or estoppel by any party. If any member of an approving Rust team serves as one of the maintainers of a target, or has any legal or employment requirement (explicit or implicit) that might affect their decisions regarding a target, they must recuse themselves from any approval decisions regarding the target's tier status, though they may otherwise participate in discussions.

This requirement does not prevent part or all of this policy from being cited in an explicit contract or work agreement (e.g. to implement or maintain support for a target). This requirement exists to ensure that a developer or team responsible for reviewing and approving a target does not face any legal threats or obligations that would prevent them from freely exercising their judgment in such approval, even if such judgment involves subjective matters or goes beyond the letter of these requirements.

Understood.

Tier 3 targets should attempt to implement as much of the standard libraries as possible and appropriate (core for most targets, alloc for targets that can support dynamic memory allocation, std for targets with an operating system or equivalent layer of system-provided functionality), but may leave some code unimplemented (either unavailable or stubbed out as appropriate), whether because the target makes it impossible to implement or challenging to implement. The authors of pull requests are not obligated to avoid calling any portions of the standard library on the basis of a tier 3 target not implementing those portions.

This target supports the whole libstd surface, since it's essentially reusing all of the x86_64-pc-windows-msvc target. Understood.

The target must provide documentation for the Rust community explaining how to build for the target, using cross-compilation if possible. If the target supports running binaries, or running tests (even if they do not pass), the documentation must explain how to run such binaries or tests for the target, using emulation if possible or dedicated hardware if necessary.

Wrote some documentation on how to build, test and cross-compile the target in the platform-support part. Hopefully it's enough to get started.

Tier 3 targets must not impose burden on the authors of pull requests, or other developers in the community, to maintain the target. In particular, do not post comments (automated or manual) on a PR that derail or suggest a block on the PR based on a tier 3 target. Do not send automated messages or notifications (via any medium, including via @) to a PR author or others involved with a PR regarding a tier 3 target, unless they have opted into such messages.

Backlinks such as those generated by the issue/PR tracker when linking to an issue or PR are not considered a violation of this policy, within reason. However, such messages (even on a separate repository) must not generate notifications to anyone involved with a PR who has not requested such notifications.

Understood.

Patches adding or updating tier 3 targets must not break any existing tier 2 or tier 1 target, and must not knowingly break another tier 3 target without approval of either the compiler team or the maintainers of the other tier 3 target.

In particular, this may come up when working on closely related targets, such as variations of the same architecture with different features. Avoid introducing unconditional uses of features that another variation of the target may not have; use conditional compilation or runtime detection, as appropriate, to let each target run code supported by that target.

Understood.

If a tier 3 target stops meeting these requirements, or the target maintainers no longer have interest or time, or the target shows no signs of activity and has not built for some time, or removing the target would improve the quality of the Rust codebase, we may post a PR to remove it; any such PR will be CCed to the target maintainers (and potentially other people who have previously worked on the target), to check potential interest in improving the situation.

Understood.

rustbot · 2023-11-21T22:06:27Z

r? @ehuss

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2023-11-21T22:06:30Z

These commits modify compiler targets.
(See the Target Tier Policy.)

ChrisDenton · 2023-11-21T22:41:56Z

This would be great to have! It's essentially splitting off Windows 7 into a separate target so I do wonder if the compiler team would be ok starting at tier 2. The code, as it stands now, would be the same but can then diverge as and when needed.

rustbot · 2023-11-21T22:52:56Z

These commits modify compiler targets.
(See the Target Tier Policy.)

ehuss · 2023-11-22T15:29:04Z

r? compiler

davidtwco · 2023-12-07T15:27:02Z

r? @davidtwco

davidtwco · 2023-12-07T16:09:01Z

As per our target policy, we should treat this as if it is a demotion of a tier one target, so we probably need to get sign-off from the compiler team to add this target via an MCP, could you submit one?

If introducing a new tier 2 or higher target that is identical to an existing Rust target except for the baseline expectations for the features or versions of CPUs, operating systems, libraries, runtime environments, and similar, then the proposed target must document to the satisfaction of the approving teams why the specific difference in baseline expectations provides sufficient value to justify a separate target.

Note that in some cases, based on the usage of existing targets within the Rust community, Rust developers or a target's maintainers may wish to modify the baseline expectations of a target, or split an existing target into multiple targets with different baseline expectations. A proposal to do so will be treated similarly to the analogous promotion, demotion, or removal of a target, according to this policy, with the same team approvals required.

For instance, if an OS version has become obsolete and unsupported, a target for that OS may raise its baseline expectations for OS version (treated as though removing a target corresponding to the older versions), or a target for that OS may split out support for older OS versions into a lower-tier target (treated as though demoting a target corresponding to the older versions, and requiring justification for a new target at a lower tier for the older OS versions).

nbigaouette · 2023-12-07T21:17:41Z

As per our target policy, we should treat this as if it is a demotion of a tier one target

Isn't the demotion already happened in MCP 651? Windows 7 support has been dropped completely, and this PR adds it back as a new (tier 3) target.

roblabla · 2023-12-08T10:38:58Z

I'd be happy to make an MCP, but I was under the impression that Windows 7 had already been demoted in MCP651, so this target is really just reintroducing its support as a new target here. Does that require an MCP too? If so, I can go ahead and make one.

Regarding Tier, I'd be happy to go straight for Tier2, but the policy states that there needs to be at least two maintainers responsible for a T2 target - I'm currently working on this alone.

davidtwco · 2023-12-08T14:06:22Z

I'd be happy to make an MCP, but I was under the impression that Windows 7 had already been demoted in MCP651, so this target is really just reintroducing its support as a new target here. Does that require an MCP too? If so, I can go ahead and make one.

I guess MCP651 can cover this - I'm not sure we've got a precedent for this change. I'm happy to merge this with tier three. I'm not too sure about using the vendor field for win7, but I suppose it's fine.

Regarding Tier, I'd be happy to go straight for Tier2, but the policy states that there needs to be at least two maintainers responsible for a T2 target - I'm currently working on this alone.

Let's keep this at tier three for now.

davidtwco · 2023-12-08T14:07:19Z

@bors r+

bors · 2023-12-08T14:07:21Z

📌 Commit e836561 has been approved by davidtwco

It is now in the queue for this repository.

…twco Add new targets {x86_64,i686}-win7-windows-msvc This PR adds two new Tier 3 targets, x86_64-win7-windows-msvc and i686-win7-windows-msvc, that aim to support targeting Windows 7 after the `*-pc-windows-msvc` target drops support for it (slated to happen in 1.76.0). # Tier 3 target policy > At this tier, the Rust project provides no official support for a target, so we place minimal requirements on the introduction of targets. > > A proposed new tier 3 target must be reviewed and approved by a member of the compiler team based on these requirements. The reviewer may choose to gauge broader compiler team consensus via a [Major Change Proposal (MCP)](https://forge.rust-lang.org/compiler/mcp.html). > > A proposed target or target-specific patch that substantially changes code shared with other targets (not just target-specific code) must be reviewed and approved by the appropriate team for that shared code before acceptance. > > - A tier 3 target must have a designated developer or developers (the "target maintainers") on record to be CCed when issues arise regarding the target. (The mechanism to track and CC such developers may evolve over time.) This is me, ```@roblabla``` on github. > - Targets must use naming consistent with any existing targets; for instance, a target for the same CPU or OS as an existing Rust target should use the same name for that CPU or OS. Targets should normally use the same names and naming conventions as used elsewhere in the broader ecosystem beyond Rust (such as in other toolchains), unless they have a very good reason to diverge. Changing the name of a target can be highly disruptive, especially once the target reaches a higher tier, so getting the name right is important even for a tier 3 target. I went with naming the target `x86_64-win7-windows-msvc`, inserting the `win7` in the vendor field (usually set to to `pc`). This is done to avoid ecosystem churn, as quite a few crates have `cfg(target_os = "windows")` or `cfg(target_env = "msvc")`, but nearly no `cfg(target_vendor = "pc")`. Since my goal is to be able to seamlessly swap to the `win7` target, I figured it'd be easier this way. > - Target names should not introduce undue confusion or ambiguity unless absolutely necessary to maintain ecosystem compatibility. For example, if the name of the target makes people extremely likely to form incorrect beliefs about what it targets, the name should be changed or augmented to disambiguate it. I believe the naming is pretty explicit. > - If possible, use only letters, numbers, dashes and underscores for the name. Periods (`.`) are known to cause issues in Cargo. The name comforms to this requirement. > - Tier 3 targets may have unusual requirements to build or use, but must not create legal issues or impose onerous legal terms for the Rust project or for Rust developers or users. > - The target must not introduce license incompatibilities. > - Anything added to the Rust repository must be under the standard Rust license (`MIT OR Apache-2.0`). > - The target must not cause the Rust tools or libraries built for any other host (even when supporting cross-compilation to the target) to depend on any new dependency less permissive than the Rust licensing policy. This applies whether the dependency is a Rust crate that would require adding new license exceptions (as specified by the `tidy` tool in the rust-lang/rust repository), or whether the dependency is a native library or binary. In other words, the introduction of the target must not cause a user installing or running a version of Rust or the Rust tools to be subject to any new license requirements. > - Compiling, linking, and emitting functional binaries, libraries, or other code for the target (whether hosted on the target itself or cross-compiling from another target) must not depend on proprietary (non-FOSS) libraries. Host tools built for the target itself may depend on the ordinary runtime libraries supplied by the platform and commonly used by other applications built for the target, but those libraries must not be required for code generation for the target; cross-compilation to the target must not require such libraries at all. For instance, `rustc` built for the target may depend on a common proprietary C runtime library or console output library, but must not depend on a proprietary code generation library or code optimization library. Rust's license permits such combinations, but the Rust project has no interest in maintaining such combinations within the scope of Rust itself, even at tier 3. > - "onerous" here is an intentionally subjective term. At a minimum, "onerous" legal/licensing terms include but are *not* limited to: non-disclosure requirements, non-compete requirements, contributor license agreements (CLAs) or equivalent, "non-commercial"/"research-only"/etc terms, requirements conditional on the employer or employment of any particular Rust developers, revocable terms, any requirements that create liability for the Rust project or its developers or users, or any requirements that adversely affect the livelihood or prospects of the Rust project or its developers or users. As far as I understand it, this target has exactly the same legal situation as the existing Tier 1 x86_64-pc-windows-msvc. > - Neither this policy nor any decisions made regarding targets shall create any binding agreement or estoppel by any party. If any member of an approving Rust team serves as one of the maintainers of a target, or has any legal or employment requirement (explicit or implicit) that might affect their decisions regarding a target, they must recuse themselves from any approval decisions regarding the target's tier status, though they may otherwise participate in discussions. > - This requirement does not prevent part or all of this policy from being cited in an explicit contract or work agreement (e.g. to implement or maintain support for a target). This requirement exists to ensure that a developer or team responsible for reviewing and approving a target does not face any legal threats or obligations that would prevent them from freely exercising their judgment in such approval, even if such judgment involves subjective matters or goes beyond the letter of these requirements. Understood. > - Tier 3 targets should attempt to implement as much of the standard libraries as possible and appropriate (core for most targets, alloc for targets that can support dynamic memory allocation, std for targets with an operating system or equivalent layer of system-provided functionality), but may leave some code unimplemented (either unavailable or stubbed out as appropriate), whether because the target makes it impossible to implement or challenging to implement. The authors of pull requests are not obligated to avoid calling any portions of the standard library on the basis of a tier 3 target not implementing those portions. This target supports the whole libstd surface, since it's essentially reusing all of the x86_64-pc-windows-msvc target. Understood. > - The target must provide documentation for the Rust community explaining how to build for the target, using cross-compilation if possible. If the target supports running binaries, or running tests (even if they do not pass), the documentation must explain how to run such binaries or tests for the target, using emulation if possible or dedicated hardware if necessary. Wrote some documentation on how to build, test and cross-compile the target in the `platform-support` part. Hopefully it's enough to get started. > - Tier 3 targets must not impose burden on the authors of pull requests, or other developers in the community, to maintain the target. In particular, do not post comments (automated or manual) on a PR that derail or suggest a block on the PR based on a tier 3 target. Do not send automated messages or notifications (via any medium, including via ````@`)``` to a PR author or others involved with a PR regarding a tier 3 target, unless they have opted into such messages. > - Backlinks such as those generated by the issue/PR tracker when linking to an issue or PR are not considered a violation of this policy, within reason. However, such messages (even on a separate repository) must not generate notifications to anyone involved with a PR who has not requested such notifications. Understood. > - Patches adding or updating tier 3 targets must not break any existing tier 2 or tier 1 target, and must not knowingly break another tier 3 target without approval of either the compiler team or the maintainers of the other tier 3 target. > - In particular, this may come up when working on closely related targets, such as variations of the same architecture with different features. Avoid introducing unconditional uses of features that another variation of the target may not have; use conditional compilation or runtime detection, as appropriate, to let each target run code supported by that target. Understood. > If a tier 3 target stops meeting these requirements, or the target maintainers no longer have interest or time, or the target shows no signs of activity and has not built for some time, or removing the target would improve the quality of the Rust codebase, we may post a PR to remove it; any such PR will be CCed to the target maintainers (and potentially other people who have previously worked on the target), to check potential interest in improving the situation. Understood.

…llaumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#118150 (Add new targets {x86_64,i686}-win7-windows-msvc) - rust-lang#118417 (Add unstable `-Zdefault-hidden-visibility` cmdline flag for `rustc`.) - rust-lang#118692 (remove redundant imports) - rust-lang#118694 (Add instance evaluation and methods to read an allocation in StableMIR) - rust-lang#118737 (Extend tidy alphabetical checking to `tests/`.) r? `@ghost` `@rustbot` modify labels: rollup

GuillaumeGomez · 2023-12-08T16:12:42Z

I think it's the one which failed in #118745.

ChrisDenton · 2023-12-08T16:43:02Z

Since the failed tests mention default_hidden_visibility, isn't it more likely to be #118417?

GuillaumeGomez · 2023-12-08T16:46:28Z

My apologies, you're right.

bors · 2023-12-09T08:41:53Z

⌛ Testing commit e836561 with merge c416699...

bors · 2023-12-09T10:38:48Z

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing c416699 to master...

rust-timer · 2023-12-09T11:58:59Z

Finished benchmarking commit (c416699): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.4%	[-1.4%, -1.4%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.4%	[-1.4%, -1.4%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 670.776s -> 669.317s (-0.22%)
Artifact size: 314.08 MiB -> 314.04 MiB (-0.01%)

seritools · 2023-12-29T00:57:48Z

@roblabla I was looking at the i686-win7-windows-msvc target - that one doesn't seem to have the vendor set to "win7". Was that intended or just missed? 👀

roblabla · 2023-12-29T11:28:08Z

Oops, that was missed.

…rieb Fix: Properly set vendor in i686-win7-windows-msvc target In rust-lang#118150 , setting the `vendor` field of the `i686-win7-windows-msvc` target was forgotten, preventing us from easily checking the target using `cfg(target_vendor)`. With this PR, we set the target vendor to "win7".

Rollup merge of rust-lang#119544 - roblabla:new-win7-targets, r=Nilstrieb Fix: Properly set vendor in i686-win7-windows-msvc target In rust-lang#118150 , setting the `vendor` field of the `i686-win7-windows-msvc` target was forgotten, preventing us from easily checking the target using `cfg(target_vendor)`. With this PR, we set the target vendor to "win7".

Pkgsrc changes: * Adapt checksums and patches. Upstream chnages: Version 1.76.0 (2024-02-08) ========================== Language -------- - [Document Rust ABI compatibility between various types] (rust-lang/rust#115476) - [Also: guarantee that char and u32 are ABI-compatible] (rust-lang/rust#118032) - [Warn against ambiguous wide pointer comparisons] (rust-lang/rust#117758) Compiler -------- - [Lint pinned `#[must_use]` pointers (in particular, `Box<T>` where `T` is `#[must_use]`) in `unused_must_use`.] (rust-lang/rust#118054) - [Soundness fix: fix computing the offset of an unsized field in a packed struct] (rust-lang/rust#118540) - [Soundness fix: fix dynamic size/align computation logic for packed types with dyn Trait tail] (rust-lang/rust#118538) - [Add `$message_type` field to distinguish json diagnostic outputs] (rust-lang/rust#115691) - [Enable Rust to use the EHCont security feature of Windows] (rust-lang/rust#118013) - [Add tier 3 {x86_64,i686}-win7-windows-msvc targets] (rust-lang/rust#118150) - [Add tier 3 aarch64-apple-watchos target] (rust-lang/rust#119074) - [Add tier 3 arm64e-apple-ios & arm64e-apple-darwin targets] (rust-lang/rust#115526) Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Add a column number to `dbg!()`] (rust-lang/rust#114962) - [Add `std::hash::{DefaultHasher, RandomState}` exports] (rust-lang/rust#115694) - [Fix rounding issue with exponents in fmt] (rust-lang/rust#116301) - [Add T: ?Sized to `RwLockReadGuard` and `RwLockWriteGuard`'s Debug impls.] (rust-lang/rust#117138) - [Windows: Allow `File::create` to work on hidden files] (rust-lang/rust#116438) Stabilized APIs --------------- - [`Arc::unwrap_or_clone`] (https://doc.rust-lang.org/stable/std/sync/struct.Arc.html#method.unwrap_or_clone) - [`Rc::unwrap_or_clone`] (https://doc.rust-lang.org/stable/std/rc/struct.Rc.html#method.unwrap_or_clone) - [`Result::inspect`] (https://doc.rust-lang.org/stable/std/result/enum.Result.html#method.inspect) - [`Result::inspect_err`] (https://doc.rust-lang.org/stable/std/result/enum.Result.html#method.inspect_err) - [`Option::inspect`] (https://doc.rust-lang.org/stable/std/option/enum.Option.html#method.inspect) - [`type_name_of_val`] (https://doc.rust-lang.org/stable/std/any/fn.type_name_of_val.html) - [`std::hash::{DefaultHasher, RandomState}`] (https://doc.rust-lang.org/stable/std/hash/index.html#structs) These were previously available only through `std::collections::hash_map`. - [`ptr::{from_ref, from_mut}`] (https://doc.rust-lang.org/stable/std/ptr/fn.from_ref.html) - [`ptr::addr_eq`](https://doc.rust-lang.org/stable/std/ptr/fn.addr_eq.html) Cargo ----- See [Cargo release notes] (https://github.com/rust-lang/cargo/blob/master/CHANGELOG.md#cargo-176-2024-02-08). Rustdoc ------- - [Don't merge cfg and doc(cfg) attributes for re-exports] (rust-lang/rust#113091) - [rustdoc: allow resizing the sidebar / hiding the top bar] (rust-lang/rust#115660) - [rustdoc-search: add support for traits and associated types] (rust-lang/rust#116085) - [rustdoc: Add highlighting for comments in items declaration] (rust-lang/rust#117869) Compatibility Notes ------------------- - [Add allow-by-default lint for unit bindings] (rust-lang/rust#112380) This is expected to be upgraded to a warning by default in a future Rust release. Some macros emit bindings with type `()` with user-provided spans, which means that this lint will warn for user code. - [Remove x86_64-sun-solaris target.] (rust-lang/rust#118091) - [Remove asmjs-unknown-emscripten target] (rust-lang/rust#117338) - [Report errors in jobserver inherited through environment variables] (rust-lang/rust#113730) This [may warn](rust-lang/rust#120515) on benign problems too. - [Update the minimum external LLVM to 16.] (rust-lang/rust#117947) - [Improve `print_tts`](rust-lang/rust#114571) This change can break some naive manual parsing of token trees in proc macro code which expect a particular structure after `.to_string()`, rather than just arbitrary Rust code. - [Make `IMPLIED_BOUNDS_ENTAILMENT` into a hard error from a lint] (rust-lang/rust#117984) - [Vec's allocation behavior was changed when collecting some iterators] (rust-lang/rust#110353) Allocation behavior is currently not specified, nevertheless changes can be surprising. See [`impl FromIterator for Vec`] (https://doc.rust-lang.org/nightly/std/vec/struct.Vec.html#impl-FromIterator%3CT%3E-for-Vec%3CT%3E) for more details. - [Properly reject `default` on free const items] (rust-lang/rust#117818)

rustbot assigned ehuss Nov 21, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 21, 2023

roblabla force-pushed the new-win7-targets branch from 0676eeb to 019a7d1 Compare November 21, 2023 22:52

This comment has been minimized.

Sign in to view

roblabla force-pushed the new-win7-targets branch from 019a7d1 to c28ac19 Compare November 22, 2023 09:18

This comment has been minimized.

Sign in to view

roblabla added 3 commits November 22, 2023 11:15

Add new x86_64-win7-windows-msvc target

ad6dd6c

Add i686-win7-windows-msvc target

85e73c1

Improve -win7-windows-msvc documentation

e836561

roblabla force-pushed the new-win7-targets branch from c28ac19 to e836561 Compare November 22, 2023 10:15

rustbot assigned TaKO8Ki and unassigned ehuss Nov 22, 2023

rustbot assigned davidtwco and unassigned TaKO8Ki Dec 7, 2023

davidtwco approved these changes Dec 8, 2023

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 8, 2023

GuillaumeGomez mentioned this pull request Dec 8, 2023

Rollup of 5 pull requests #118745

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 9, 2023

bors merged commit c416699 into rust-lang:master Dec 9, 2023
12 checks passed

rustbot added this to the 1.76.0 milestone Dec 9, 2023

deltragon mentioned this pull request Dec 17, 2023

Use a hardcoded constant instead of calling OpenProcessToken. #119032

Merged

bjorn3 mentioned this pull request Dec 17, 2023

Can't install for low end machines #119038

Closed

roblabla mentioned this pull request Jan 3, 2024

Fix: Properly set vendor in i686-win7-windows-msvc target #119544

Merged

seritools mentioned this pull request Jan 4, 2024

Relax the build target checks in windows-targets sub-crates microsoft/windows-rs#2774

Merged

RalfJung mentioned this pull request Feb 4, 2024

Windows support schedule 2024 rust-lang/compiler-team#651

Closed

3 tasks

ChrisDenton mentioned this pull request Feb 5, 2024

Windows support update rust-lang/blog.rust-lang.org#1240

Merged

AlexTMjugador mentioned this pull request May 3, 2024

OxiPNG stopped working on Windows 7 shssoichiro/oxipng#617

Closed

saethlin mentioned this pull request May 3, 2024

GetSystemTimePreciseAsFileTime #124666

Closed

sergeevabc mentioned this pull request May 6, 2024

FD version 10 stopped working on Windows 7 sharkdp/fd#1550

Closed

1 task

hellishvictor mentioned this pull request Jun 15, 2024

"warning: unused imports: DisplayWidth, `TextCellContents'" eza-community/eza#1024

Open

ZeWaka mentioned this pull request Jul 21, 2024

Windows 7 tgstation/rust-g#183

Merged

Greatness7 mentioned this pull request Aug 30, 2024

rust-version = “1.79” Is this really necessary right now? vizia/vizia#495

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new targets {x86_64,i686}-win7-windows-msvc #118150

Add new targets {x86_64,i686}-win7-windows-msvc #118150

roblabla commented Nov 21, 2023 •

edited

Loading

rustbot commented Nov 21, 2023

rustbot commented Nov 21, 2023

ChrisDenton commented Nov 21, 2023

rustbot commented Nov 21, 2023

This comment has been minimized.

This comment has been minimized.

ehuss commented Nov 22, 2023

davidtwco commented Dec 7, 2023

davidtwco commented Dec 7, 2023

nbigaouette commented Dec 7, 2023

roblabla commented Dec 8, 2023

davidtwco commented Dec 8, 2023 •

edited

Loading

davidtwco commented Dec 8, 2023

bors commented Dec 8, 2023

GuillaumeGomez commented Dec 8, 2023

ChrisDenton commented Dec 8, 2023

GuillaumeGomez commented Dec 8, 2023

bors commented Dec 9, 2023

bors commented Dec 9, 2023

rust-timer commented Dec 9, 2023

seritools commented Dec 29, 2023

roblabla commented Dec 29, 2023

Add new targets {x86_64,i686}-win7-windows-msvc #118150

Add new targets {x86_64,i686}-win7-windows-msvc #118150

Conversation

roblabla commented Nov 21, 2023 • edited Loading

Tier 3 target policy

rustbot commented Nov 21, 2023

rustbot commented Nov 21, 2023

ChrisDenton commented Nov 21, 2023

rustbot commented Nov 21, 2023

This comment has been minimized.

This comment has been minimized.

ehuss commented Nov 22, 2023

davidtwco commented Dec 7, 2023

davidtwco commented Dec 7, 2023

nbigaouette commented Dec 7, 2023

roblabla commented Dec 8, 2023

davidtwco commented Dec 8, 2023 • edited Loading

davidtwco commented Dec 8, 2023

bors commented Dec 8, 2023

GuillaumeGomez commented Dec 8, 2023

ChrisDenton commented Dec 8, 2023

GuillaumeGomez commented Dec 8, 2023

bors commented Dec 9, 2023

bors commented Dec 9, 2023

rust-timer commented Dec 9, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

seritools commented Dec 29, 2023

roblabla commented Dec 29, 2023

roblabla commented Nov 21, 2023 •

edited

Loading

davidtwco commented Dec 8, 2023 •

edited

Loading