-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 13 pull requests #119516
Closed
Closed
Rollup of 13 pull requests #119516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not important which one is used since `is_dangling` does not access memory, but `*const` removes the needs of `*const T` -> `*mut T` casts in `from_raw_in`.
The original tracking issue was superseded by a new one (constrainted naked functions) and therefore is closed.
and calculate the z-indices of things that go over the sidebar
No reason why this needs to be a `bug!()`.
…e8472 Document that File does not buffer reads/writes ...and refer to `BufReader`/`BufWriter`. This is a common source of efficiency issues in Rust programs written naively. Including this information with the `File` docs, and adding a link to the wrapper types, will help discoverability.
…ulacrum rc: Take *const T in is_dangling It is not important which one is used since `is_dangling` does not access memory, but `*const` removes the needs of `*const T` -> `*mut T` casts in `from_raw_in`.
…ne, r=oli-obk Rename `TyCtxt::is_closure` to `TyCtxt::is_closure_or_coroutine` This function has always been used to test whether the def-id was a closure **or** coroutine: https://github.com/rust-lang/rust/pull/118311/files#diff-69ebec59f7d38331dd1be84ede7957977dcaa39e30ed2869b04aa8c99b2079ccR552 -- the name is just confusing because it disagrees with other fns named `is_closure`, like `Ty::is_closure`. So let's rename it.
Update tracking issue of naked_functions The original tracking issue rust-lang#32408 was superseded by the new one rust-lang#90957 (constrainted naked functions) and therefore is closed.
…, r=compiler-errors Pretty-print always-const trait predicates correctly Follow-up to rust-lang#119099. r? fee1-dead
…iddle rustdoc ui: adjust tooltip z-index to be above sidebar In rust-lang#115660 the sidebar's z-index was changed to 100. This PR changes the tooltip's z-index to 101 to be above the sidebar again. Fixes [after beta-backport] rust-lang#119472.
…, r=compiler-errors Remove two unused feature gates from rustc_query_impl
…Nilstrieb Minor improvements in comment on `freshen.rs` - Removed a stray "if" - Changed a numeric "2" to "two" because it reads better
Update books ## rust-lang/reference 1 commits in f9f5b5babd95515e7028c32d6ca4d9790f64c146..3565c7978cfc9662f5963b135690ff9cbbfa0318 2023-12-29 21:01:19 UTC to 2023-12-29 21:01:19 UTC - Use proper footnote for number literals `_` separator note (rust-lang/reference#1444) ## rust-lang/rust-by-example 1 commits in 4c2b24ff9d9cf19f2fcff799a3a49b9a2c50ae8e..c0be6299e52e4164c30ba6f41bd0ad0aaee64972 2023-12-21 15:22:11 UTC to 2023-12-21 15:22:11 UTC - point to raw indentifiers, talking about fields (rust-lang/rust-by-example#1789) ## rust-lang/rustc-dev-guide 5 commits in 0610665a8687b1b0aa037917a1598b9f2a21e3ef..d13e85152a977cd0bcaf583cf5f49e86225697de 2023-12-30 09:58:25 UTC to 2023-12-19 10:02:34 UTC - Prominently mention `profiler = true` on the coverage page (rust-lang/rustc-dev-guide#1844) - Add a description of `unpretty=hir` to the HIR docs (rust-lang/rustc-dev-guide#1842) - Fix typo in unsize docs (rust-lang/rustc-dev-guide#1843) - Suggest `gcc_multi` to make `mir_opts` run on nixos (rust-lang/rustc-dev-guide#1841) - bootstrapping: Clarify that stage0 std code is not executed to produce stage1 compiler (rust-lang/rustc-dev-guide#1840)
…ompiler-errors Deny defaults for higher-ranked generic parameters Fixes rust-lang#119489 (incl. rust-lang#119489 (comment)). Partially reverts rust-lang#119042. cc `@bvanjoi` r? `@compiler-errors` or compiler
…strieb Update deadlinks of `strict_provenance` lints Some hyperlinks on the following page redirect to 404 pages: <https://doc.rust-lang.org/rustc/lints/listing/allowed-by-default.html#explanation-5> --- `@rustbot` label +A-docs
…, r=fee1-dead Don't synthesize host effect params for trait associated functions marked const Fixes rust-lang#113378. r? fee1-dead or compiler
Mark myself as back from leave
rustbot
added
A-meta
Area: Issues & PRs about the rust-lang/rust repository itself
A-query-system
Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
rollup
A PR which is a rollup
labels
Jan 2, 2024
In preparation for when the tree reopens. See also. |
@bors r+ rollup=never p=13 |
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jan 2, 2024
This was referenced Jan 2, 2024
Merged
bors
added
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-meta
Area: Issues & PRs about the rust-lang/rust repository itself
A-query-system
Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)
rollup
A PR which is a rollup
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
TyCtxt::is_closure
toTyCtxt::is_closure_or_coroutine
#119444 (RenameTyCtxt::is_closure
toTyCtxt::is_closure_or_coroutine
)freshen.rs
#119487 (Minor improvements in comment onfreshen.rs
)strict_provenance
lints #119498 (Update deadlinks ofstrict_provenance
lints)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup