-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase visibility of join_path
and split_paths
#119748
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
48eabf8
to
3e64f68
Compare
@rustbot label +A-docs |
3e64f68
to
aca631f
Compare
I have mixed feelings about the doc alias. If I'm a new user doing a search for "path" then I'm probably looking for path - see std::env::split_paths |
r? libs-api |
@tgross35 This is fine, but the doc aliases should be removed. Searching for "path" should point users to the |
Add some crosslinking among `std::env` pages. Also add aliases to help anyone searching for `PATH`.
0de3677
to
dbb98e6
Compare
Slipped my mind, removed the aliases so this should be ready. (squashed the typo fix commit) @rustbot ready |
@bors r+ rollup |
…nieu Increase visibility of `join_path` and `split_paths` Add some crosslinking among `std::env` pages to make it easier to discover `join_paths` and `split_paths`. Also add aliases to help anyone searching for `PATH`.
…nieu Increase visibility of `join_path` and `split_paths` Add some crosslinking among `std::env` pages to make it easier to discover `join_paths` and `split_paths`. Also add aliases to help anyone searching for `PATH`.
Rollup of 11 pull requests Successful merges: - rust-lang#119748 (Increase visibility of `join_path` and `split_paths`) - rust-lang#120291 (Have `String` use `SliceIndex` impls from `str`) - rust-lang#121130 (Suggest moving definition if non-found macro_rules! is defined later) - rust-lang#121723 (Two diagnostic things) - rust-lang#121740 (Changing some attributes to only_local.) - rust-lang#121745 (Deeply normalize obligations in `refining_impl_trait`) - rust-lang#121748 (Restore the standard library review rotation to its former glory) - rust-lang#121768 (Implement unwind safety for Condvar on all platforms ) - rust-lang#121777 (Fix typo in `rustc_passes/messages.ftl`) - rust-lang#121778 (Document potential memory leak in unbounded channel) - rust-lang#121779 (Remove unused diagnostic struct) r? `@ghost` `@rustbot` modify labels: rollup
Rollup of 10 pull requests Successful merges: - rust-lang#119748 (Increase visibility of `join_path` and `split_paths`) - rust-lang#120291 (Have `String` use `SliceIndex` impls from `str`) - rust-lang#121723 (Two diagnostic things) - rust-lang#121740 (Changing some attributes to only_local.) - rust-lang#121745 (Deeply normalize obligations in `refining_impl_trait`) - rust-lang#121748 (Restore the standard library review rotation to its former glory) - rust-lang#121768 (Implement unwind safety for Condvar on all platforms ) - rust-lang#121777 (Fix typo in `rustc_passes/messages.ftl`) - rust-lang#121778 (Document potential memory leak in unbounded channel) - rust-lang#121779 (Remove unused diagnostic struct) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#119748 - tgross35:suggest-path-split, r=Amanieu Increase visibility of `join_path` and `split_paths` Add some crosslinking among `std::env` pages to make it easier to discover `join_paths` and `split_paths`. Also add aliases to help anyone searching for `PATH`.
…llaumeGomez Rollup of 10 pull requests Successful merges: - rust-lang#118217 (Document which methods on `f64` are precise) - rust-lang#119748 (Increase visibility of `join_path` and `split_paths`) - rust-lang#121412 (platform docs: clarify hexagon-unknown-none-elf example, add hexagon-unknown-linux-musl) - rust-lang#121654 (Fix `async Fn` confirmation for `FnDef`/`FnPtr`/`Closure` types) - rust-lang#121700 (CFI: Don't compress user-defined builtin types) - rust-lang#121765 (add platform-specific function to get the error number for HermitOS) - rust-lang#121781 (bootstrap/format: send larger batches to rustfmt) - rust-lang#121788 (bootstrap: fix clap deprecated warnings) - rust-lang#121792 (Improve renaming suggestion when item starts with underscore) - rust-lang#121793 (Document which methods on `f32` are precise) r? `@ghost` `@rustbot` modify labels: rollup
…llaumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#119748 (Increase visibility of `join_path` and `split_paths`) - rust-lang#120820 (Enable CMPXCHG16B, SSE3, SAHF/LAHF and 128-bit Atomics (in nightly) in Windows x64) - rust-lang#121000 (pattern_analysis: rework how we hide empty private fields) - rust-lang#121376 (Skip unnecessary comparison with half-open range patterns) - rust-lang#121596 (Use volatile access instead of `#[used]` for `on_tls_callback`) - rust-lang#121669 (Count stashed errors again) - rust-lang#121783 (Emitter cleanups) r? `@ghost` `@rustbot` modify labels: rollup
It keeps getting skipped when I make rollups so just trying to see if bors somehow lost its state by re-approving it. @bors r=Amanieu rollup |
💡 This pull request was already approved, no need to approve it again.
|
Foiled again! Rollup completed and everything got merged but this |
Seems like it was merged tho? 06d4878 Not sure what's going on there. |
Ahhhh wtf Bors merged those two from before I force pushed, which is before this PR was approved. That's not right |
It seems bors r+ picked up a stale commit: #119748 (comment) Despite the force-push that was done here 25h before the r+: #119748 (comment) |
Maybe make a new PR that fixes it to be what it should have been? You could also maybe try closing and reopening this PR but at this point I feel like maybe we should give it up as a lost cause 😔 |
Remove aliases for `split_paths` and `join_paths` as should have been done in <rust-lang#119748> (Bors merged the wrong commit).
I just made a new PR to fix this one up #121809, indeed not worth sorting this specific one out. Just spooky 💀 |
… r=Amanieu Remove doc aliases to PATH Remove aliases for `split_paths` and `join_paths` as should have been done in <rust-lang#119748> (Bors merged the wrong commit).
Rollup merge of rust-lang#121809 - tgross35:suggest-path-split-fixup, r=Amanieu Remove doc aliases to PATH Remove aliases for `split_paths` and `join_paths` as should have been done in <rust-lang#119748> (Bors merged the wrong commit).
Add some crosslinking among
std::env
pages to make it easier to discoverjoin_paths
andsplit_paths
. Also add aliases to help anyone searching forPATH
.